Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer interface lacks getters for many properties #1074

Open
stephengold opened this issue Apr 20, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@stephengold
Copy link
Contributor

commented Apr 20, 2019

The com.jme3.renderer.Renderer interface defines setAlphaToCoverage(), setBackgroundColor(), setClipRect(), setDefaultAnisotropicFilter(), setDepthRange(), setLinearizeSrgbImages(), setMainFrameBufferSrgb(), and setViewPort(). However, it does not provide getters for any of these properties.

Runtime access to these properties might aid in debugging render issues.

@stephengold

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2019

Further investigation indicates that many of these methods are used dynamically by the RenderManager: setBackgroundColor(), setClipRect(), setDepthRange(), and setViewPort(). The corresponding properties are probably of little interest to JME users, so perhaps skip them.

Properties of interest to users include "alphaToCoverage" and "defaultAnisotropicFilter". Not sure yet about "linearizeSrgbImages" and "mainFrameBufferSrgb".

@quazi-irfan

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

I'll take a look at it tonight.

@stephengold stephengold added this to the v3.3.0 milestone Jun 18, 2019

@stephengold

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

It looks like "linearizeSrgbImages" and "mainFrameBufferSrgb" are set during initialization of the JmeContext and seldom changed thereafter. I infer that their settings might be of interest to users. I'll leave this issue open in case someone wants to implement them in the style of PR #1093.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.