updateBound() is missing in native GImpactCollisionShape #188

Closed
jimbok8 opened this Issue Nov 17, 2014 · 2 comments

Projects

None yet

3 participants

@jimbok8
jimbok8 commented Nov 17, 2014

updateBound() has been commented out in in native GImpactCollisionShape

fragment for jme3-bullet version:
// ((GImpactMeshShape)objectId).updateBound();
// objectId.setLocalScaling(Converter.convert(getScale()));
// objectId.setMargin(margin);
meshId = NativeMeshUtil.createTriangleIndexVertexArray(triangleIndexBase, vertexBase, numTriangles, numVertices, vertexStride, triangleIndexStride);

fragment for jme3-jbullet version:
cShape = new GImpactMeshShape(tiv);
cShape.setLocalScaling(Converter.convert(worldScale));
((GImpactMeshShape)cShape).updateBound();

I suspect this came about during creation of '''NativeMeshUtil.createTriangleIndexVertexArray()''' routine.

@jimbok8
jimbok8 commented Jan 9, 2015

Please can this be assigned as a bug and if pssoible fixed! Thanks.

@shadowislord shadowislord added the bug label Jan 9, 2015
@shadowislord
Member

If you would like, you can make a pull request with the fix .. The person who is maintaining the physics support is not currently available.

@Dokthar Dokthar added a commit to Dokthar/jmonkeyengine that referenced this issue Oct 6, 2015
@Dokthar Dokthar GImpactCollisionShape : fix for #188, added a call to updateBound() i…
…n native jni binding, just after creating the shape, (native createShape() method)
06d6f08
@Nehon Nehon added a commit that referenced this issue Nov 2, 2015
@Nehon Nehon Merge branch 'master' into PBRisComing
* master: (94 commits)
  First attempt to fix a bug reported by david_bernard_31, the size of the strings in the shader code was wrongly computed for the JOGL backend
  Allows to choose between the forward compatible profile and the backward compatible profile in the JOGL backend
  Displays the JOGL version instead of the NEWT version
  Updates JOGL (2.3.2)
  Bugfix: fix to importing blend files with linked content.
  native loader: set lwjgl library path for lwjgl3
  Updated lwjgl3 module to use LWJGL 3.0.0b #35 which is the current stable build.
  Change duplicated docstring in FlyByCamera.unregisterInput
  light : fixed pointLight v. bounding sphere unit test
  light : replaced duplicated code by methods from Intersection
  Removed native library jemalloc.dll for LWJGL3 as this will not be needed until 3.0.0b and after.
  light : added unit tests for the new support of bounding spheres intersections (for lightFilter)
  Fixed Issue #46 : The MaterialViewer will now simply ignore not available textures instead of crashing
  Lights (see #362) : added light v. sphere intersection, and implementations of intersectsSphere(), second attempt
  GImpactCollisionShape : fix for #188, added a call to updateBound() in native jni binding, just after creating the shape, (native createShape() method)
  Bugfix: fixed a bug that caused importer to crash when the author of the blend file assigned non existing UV coordinates group name to a mesh.
  Bugfix: fixed a bug that caused subdivision surface modifier to crash if at least one not connected vertex was in the mesh.
  The LWJGL 3 renderer was missing a call to GLContext.createFromCurrent(), sorted now.
  Changed the default app title in AppSettings to use the full name string from JmeVersion. This way no more manual changing of this will be needed for future versions. This also closes #320 which highlighted this issue. Thanks @8Keep.
  Fixed #316 where some post processing effects were not working when using OPENGL_3 renderer due to an error in the fragment shader.
  ...
c47da8e
@MeFisto94 MeFisto94 pushed a commit to MeFisto94/jmonkeyengine that referenced this issue Feb 26, 2016
@Nehon Nehon Merge branch 'master' into PBRisComing
* master: (94 commits)
  First attempt to fix a bug reported by david_bernard_31, the size of the strings in the shader code was wrongly computed for the JOGL backend
  Allows to choose between the forward compatible profile and the backward compatible profile in the JOGL backend
  Displays the JOGL version instead of the NEWT version
  Updates JOGL (2.3.2)
  Bugfix: fix to importing blend files with linked content.
  native loader: set lwjgl library path for lwjgl3
  Updated lwjgl3 module to use LWJGL 3.0.0b #35 which is the current stable build.
  Change duplicated docstring in FlyByCamera.unregisterInput
  light : fixed pointLight v. bounding sphere unit test
  light : replaced duplicated code by methods from Intersection
  Removed native library jemalloc.dll for LWJGL3 as this will not be needed until 3.0.0b and after.
  light : added unit tests for the new support of bounding spheres intersections (for lightFilter)
  Fixed Issue #46 : The MaterialViewer will now simply ignore not available textures instead of crashing
  Lights (see #362) : added light v. sphere intersection, and implementations of intersectsSphere(), second attempt
  GImpactCollisionShape : fix for #188, added a call to updateBound() in native jni binding, just after creating the shape, (native createShape() method)
  Bugfix: fixed a bug that caused importer to crash when the author of the blend file assigned non existing UV coordinates group name to a mesh.
  Bugfix: fixed a bug that caused subdivision surface modifier to crash if at least one not connected vertex was in the mesh.
  The LWJGL 3 renderer was missing a call to GLContext.createFromCurrent(), sorted now.
  Changed the default app title in AppSettings to use the full name string from JmeVersion. This way no more manual changing of this will be needed for future versions. This also closes #320 which highlighted this issue. Thanks @8Keep.
  Fixed #316 where some post processing effects were not working when using OPENGL_3 renderer due to an error in the fragment shader.
  ...
9027481
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment