Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for com.jme3.math.Vector3f #1040

Merged

Conversation

Projects
None yet
3 participants
@James-Adam
Copy link

commented Mar 15, 2019

Hi,

In reference to a PR I made 3 days ago, it was mentioned that you might be interested in receiving additional tests for classes in jmonkeyengine. One such class was com.jme3.mathVector3f. This PR contains a suite of tests, again using Diffblue Cover to assist with writing, that brings this class up to 97% coverage according the IntelliJ's internal coverage runner.

I wasn't able to find any behaviours that struck me as obviously bugs, however.

If you're still interested in such, i'll be taking a look at the other suggested classes in the coming days and writing some tests to increase their coverage, too.

@stephengold

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

Thank you for your contribution. If you could look at the other suggested classes, that'd be great.

@stephengold stephengold merged commit fe03a9b into jMonkeyEngine:master Mar 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stephengold stephengold added this to the v3.2.3 milestone Mar 17, 2019

@quazi-irfan

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

@stephengold What other classes need testing coverage?

@stephengold

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

Few of the classes in JME are adequately tested, in my opinion. Last week @Ali-RS and I suggested com.jme3.anim, com.jme3.renderer.Camera, and com.jme3.scene. (#1039)

This PR was dropped from the JME v3.2.3 release because it uses Vector3f.isSimilar(), which doesn't exist in the v3.2 branch. This PR should be included in JME v3.3, assuming that ever happens, so I'll update the Milestone accordingly.

@stephengold stephengold modified the milestones: v3.2.3, v3.3.0 Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.