Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Texture Formats #839

Merged
merged 3 commits into from May 18, 2018

Conversation

Projects
None yet
4 participants
@TehLeo
Copy link
Contributor

commented Mar 8, 2018

Added texture formats R16F, R32F, RG16F, RG32F.
Added documentation for Format.Image elements.

TehLeo
@@ -253,77 +253,238 @@
* Requires {@link Caps#SharedExponentTexture}.
*/
RGB9E5(32,true),

@Deprecated
Reserved11(0),

This comment has been minimized.

Copy link
@shadowislord

shadowislord Mar 19, 2018

Member

Adding this here changes the ordinals for the formats, which would break serialization (unfortunately, it uses the enum ordinal...)
New formats always have to be added at the bottom, and any existing formats can only be renamed, not removed

@shadowislord

This comment has been minimized.

Copy link
Member

commented Mar 19, 2018

What's the value of these formats? Where would they be used? Why are existing formats inadequate?

@TehLeo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2018

R16F, R32F, RG16F, RG32F are standard formats required by opengl spec.
They are useful for various things, such as lookup tables, etc. I am currently using them in my wip volumetric cloud rendering.

I thought changing the order of the enum might cause issues, but did it to sort values in more meaningful way. I'll redo the request to include the formats at the end.

TehLeo added some commits Mar 20, 2018

TehLeo TehLeo
@TehLeo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2018

With the new request: The order of the enum elements is preserved. I have added the 4 formats at the end and added comments for the integer formats.

@Nehon

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2018

@shadowislord is that ok for you ?
Can I merge this PR?

@shadowislord

This comment has been minimized.

Copy link
Member

commented May 2, 2018

@Nehon
OK. It seems those formats are already there though

@Nehon Nehon merged commit c72b73e into jMonkeyEngine:master May 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Nehon

This comment has been minimized.

Copy link
Contributor

commented May 18, 2018

Thanks

riccardobl added a commit to riccardobl/jmonkeyengine that referenced this pull request Aug 20, 2018

@stephengold stephengold added this to the v3.3.0 milestone Dec 20, 2018

@stephengold

This comment has been minimized.

Copy link
Contributor

commented Feb 20, 2019

This PR is being discussed for possible inclusion in JME v3.2.3:
https://hub.jmonkeyengine.org/t/next-release-s-of-the-engine/40856/126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.