Skip to content

Moved strings from codechecks to bundle.properties#50

Merged
MeFisto94 merged 4 commits into
jMonkeyEngine:masterfrom
grizeldi:master
Apr 8, 2016
Merged

Moved strings from codechecks to bundle.properties#50
MeFisto94 merged 4 commits into
jMonkeyEngine:masterfrom
grizeldi:master

Conversation

@grizeldi

@grizeldi grizeldi commented Apr 8, 2016

Copy link
Copy Markdown
Member

Moved strings from codechecks to a separate bundle as a part of preparation for a larger refactor of codechecks package.

@MeFisto94

Copy link
Copy Markdown
Member

Looks good to me,
I assume you somehow checked that everything works (i.e. you don't have a typo in the key preventing it from loading?)

(I don't have the time atm to do a check by myself)

@grizeldi

grizeldi commented Apr 8, 2016

Copy link
Copy Markdown
Member Author

I tested updateHint and tempVarsHint. ReadOnlyPrimitives is bugged right now so can't test it. And I don't know on what should internalHint trigger.

@MeFisto94 MeFisto94 merged commit 16922cd into jMonkeyEngine:master Apr 8, 2016
@MeFisto94

Copy link
Copy Markdown
Member

Okay, we will see in the future then.
Thanks for your Contribution! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants