Added SeqTest.verifyIteratorValidity() method #310
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose a new private method in
SeqTest
:This method verifies whether our non-terminal
Seq
operations (e.g.limitWhile
,partition
,splitAt
) behave as expected, i.e.:Spliterator.tryAdvance
that returnstrue
actually calls givenaction
source
sequence is equal toexpectedCount
Iterator.hasNext
does not fetch any extra element from the source sequence (such calls are valid and should be "safe")Using this method I detected two defects: #308 and #309.