Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Source.of(InputStream, int) and Source.of(Reader, int) to create length limited sources #12667

Closed
lukaseder opened this issue Nov 26, 2021 · 1 comment
Closed

Add Source.of(InputStream, int) and Source.of(Reader, int) to create length limited sources #12667

lukaseder opened this issue Nov 26, 2021 · 1 comment
Labels
C: Functionality E: All Editions P: Medium R: Fixed T: Enhancement
Projects
3.16 Other improvements
Milestone
Version 3.16.0

Comments

@lukaseder
Copy link
Member

Some use cases require limiting an InputStream to a certain length. We currently don't have any auxiliary API in Source for that. Would be useful as an overload.

This can be used to implement #12666, because we cannot use InputStream.readNBytes() yet, which was added in Java 11 only
@lukaseder lukaseder added this to the Version 3.16.0 milestone Nov 26, 2021
@lukaseder lukaseder added this to To do in 3.16 Other improvements via automation Nov 26, 2021
@lukaseder lukaseder mentioned this issue Nov 26, 2021
Closed
lukaseder added a commit that referenced this issue Nov 26, 2021
@lukaseder
[#12667] Add Source.of(InputStream, int) to create length
bd1d0ea 
limited input stream sources
lukaseder added a commit that referenced this issue Nov 26, 2021
@lukaseder
[#12667] Add Source.of(InputStream, int) to create length
161750e 
limited input stream sources
@lukaseder
Copy link
Member Author

Fixed in jOOQ 3.16.0 and 3.15.5 (#12668) (Backport because it helps implement a bug fix #12666)

3.16 Other improvements automation moved this from To do to Done Nov 26, 2021
lukaseder added a commit that referenced this issue Nov 26, 2021
@lukaseder
[#12667] Add also Source.of(Reader, int)
3aa78a1
lukaseder added a commit that referenced this issue Nov 26, 2021
@lukaseder
[#12667] Add also Source.of(Reader, int)
935a3f5
@lukaseder lukaseder changed the title Add Source.of(InputStream, int) to create length limited input stream sources Add Source.of(InputStream, int) and Source.of(Reader, int) to create length limited sources Nov 26, 2021
lukaseder added a commit that referenced this issue Nov 26, 2021
@lukaseder
[#12667] Prevent underflows
bb0ac6f
lukaseder added a commit that referenced this issue Nov 26, 2021
@lukaseder
[#12667] Prevent underflows
2b5da01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Functionality E: All Editions P: Medium R: Fixed T: Enhancement
Projects
No open projects
3.16 Other improvements
  
Done
Milestone
Version 3.16.0
Development

No branches or pull requests
1 participant
@lukaseder