Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code generation fails to generate valid java for stored procedures that accept parameters named configuration. #2502

Closed
FlameDuck opened this Issue Jun 4, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@FlameDuck
Copy link

commented Jun 4, 2013

When trying to generate jOOQ classes for our database we get a method with the following signiture in our "Routines.java"

public static void updateeventcontainers(org.jooq.Configuration configuration, java.lang.String configuration)

Now this doesn't quite work, because one is fed as a parameter, and the other is invoked on execute, and the compiler can't figure out which is which.

Now we can of course manually go in and change this to get it to work, however we really wanted to use this with our CI setup, and manual steps aren't very CI friendly.

If it makes any difference I'm using jOOQ 3.0.1 via Maven 3.0.4 and MSSQL Server 2012 with jTDS.

@ghost ghost assigned lukaseder Jun 4, 2013

@lukaseder

This comment has been minimized.

Copy link
Member

commented Jun 4, 2013

Thanks for reporting this. Unfortunately, there is currently no name-mangling done for generated procedure arguments. This should be fixed ASAP

A merge will be done for 3.0.2, 2.7, 2.6.5

lukaseder added a commit that referenced this issue Jun 10, 2013

[#2502] [#2515] Code generation fixes - Added test artefacts
* [#2502] Code generation fails to generate valid java for stored
procedures that accept parameters named configuration.
* [#2515] Compilation errors when generating code for artefacts that
differ only by a trailing underscore(s): A and A_ and A__

lukaseder added a commit that referenced this issue Jun 10, 2013

[#2502] Code generation fails to generate valid java for stored
procedures that accept parameters named configuration.

lukaseder added a commit that referenced this issue Jun 10, 2013

[#2502] [#2515] Code generation fixes - Regenerated test data
* [#2502] Code generation fails to generate valid java for stored
procedures that accept parameters named configuration.
* [#2515] Compilation errors when generating code for artefacts that
differ only by a trailing underscore(s): A and A_ and A__

@lukaseder lukaseder closed this Jun 10, 2013

@lukaseder

This comment has been minimized.

Copy link
Member

commented Jun 10, 2013

I've released a new 3.1.0-SNAPSHOT version containing the fix:
https://oss.sonatype.org/content/repositories/snapshots/org/jooq/

Thanks again for reporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.