New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid adding the LoggerListener if the log level is more than DEBUG #6747

Closed
lukaseder opened this Issue Oct 30, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@lukaseder
Member

lukaseder commented Oct 30, 2017

This is a similar optimisation to #6746. Currently, the internal ExecuteListeners utility that abstracts over the loop over all configured ExecuteListener instances always adds a LoggerListener, if Settings.isExecuteLogging() is active (which it is, by default).

However, users may still turn off logging in their configuration. The LoggerListener only logs on DEBUG and TRACE levels. If it is configured to be mute, we shouldn't add the LoggerListener at all, and by consequence (following #6746), we shouldn't allocate ExecuteListeners either, because it will be empty by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment