Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataType.getDataType(Configuration) turns this on dialect specific data types #9384

Closed
lukaseder opened this issue Oct 16, 2019 · 1 comment

Comments

@lukaseder
Copy link
Member

@lukaseder lukaseder commented Oct 16, 2019

When calling

H2DataType.VARCHAR.getDataType(DSL.using(SQLDialect.ORACLE).configuration()).toString()

One would expect to get varchar2, but varchar is returned. This is because of:

// If this is another dialect's specific data type, recurse
else {
getSQLDataType().getDataType(configuration);
}

It is missing a return statement.

@lukaseder

This comment has been minimized.

Copy link
Member Author

@lukaseder lukaseder commented Oct 16, 2019

Fixed in 3.13.0. Backport scheduled for 3.12.2 (#9385)

@lukaseder lukaseder closed this Oct 16, 2019
3.13 Other improvements automation moved this from To do to Done Oct 16, 2019
@lukaseder lukaseder added the R: Fixed label Oct 16, 2019
@lukaseder lukaseder self-assigned this Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.