Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

DoctrineDBALImplementationLoader review with the current application state #23

Merged
merged 3 commits into from

3 participants

@adou600

All the skipped tests in DoctrineDBALImplementationLoader.php have been commented (with the corresponding issue) or have been removed if no error were thrown.

@dbu dbu commented on the diff
tests/inc/DoctrineDBALImplementationLoader.php
@@ -14,22 +14,16 @@ protected function __construct()
parent::__construct('Jackalope\RepositoryFactoryDoctrineDBAL', $GLOBALS['phpcr.workspace']);
$this->unsupportedChapters = array(
@dbu Owner
dbu added a note

please keep ShareableNodes, AccessControlManagement, LifecycleManagement, RetentionAndHold, SameNameSiblings in the list of things to skip. the reason you can currently remove them without failure is that there are no tests implemented for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@travisbot

This pull request passes (merged ef7c2c3 into 6baac30).

@travisbot

This pull request passes (merged f4efd91 into 8af1b8a).

@dbu dbu merged commit abdc4b4 into jackalope:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 25 additions and 29 deletions.
  1. +25 −29 tests/inc/DoctrineDBALImplementationLoader.php
View
54 tests/inc/DoctrineDBALImplementationLoader.php
@@ -14,22 +14,21 @@ protected function __construct()
parent::__construct('Jackalope\RepositoryFactoryDoctrineDBAL', $GLOBALS['phpcr.workspace']);
$this->unsupportedChapters = array(
@dbu Owner
dbu added a note

please keep ShareableNodes, AccessControlManagement, LifecycleManagement, RetentionAndHold, SameNameSiblings in the list of things to skip. the reason you can currently remove them without failure is that there are no tests implemented for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
- 'PermissionsAndCapabilities',
- 'Observation',
- 'ShareableNodes',
- 'Versioning',
- 'AccessControlManagement',
- 'Locking',
- 'LifecycleManagement',
- 'RetentionAndHold',
- 'SameNameSiblings',
- 'OrderableChildNodes',
+ 'ShareableNodes', //TODO: Not implemented, no test currently written for it
+ 'AccessControlManagement', //TODO: Not implemented, no test currently written for it
+ 'LifecycleManagement', //TODO: Not implemented, no test currently written for it
+ 'RetentionAndHold', //TODO: Not implemented, no test currently written for it
+ 'SameNameSiblings', //TODO: Not implemented, no test currently written for it
+ 'PermissionsAndCapabilities', //TODO: Transport does not support permissions
+ 'Observation', //TODO: Transport does not support observation
+ 'Versioning', //TODO: Transport does not support versioning
+ 'Locking', //TODO: Transport does not support locking
);
$this->unsupportedCases = array(
- 'Writing\\MoveMethodsTest',
- 'Query\\XPath',
- 'Query\\Sql1'
+ 'Writing\\MoveMethodsTest', //TODO: Moving nodes is not yet implemented
+ 'Query\\XPath', //TODO: Query language 'xpath' not yet implemented.
+ 'Query\\Sql1' //TODO: Query language 'sql' not yet implemented
);
$this->unsupportedTests = array(
@@ -45,8 +44,7 @@ protected function __construct()
'Query\\QueryManagerTest::testGetQueryInvalid',
'Query\\QueryObjectSql2Test::testGetStoredQueryPath',
- //call to undefined method Jackalope\Query\QOM\Join::getNodeTypeName()
- //in /jackalope-doctrine-dbal/src/Jackalope/Transport/DoctrineDBAL/Client.php on line 1513
+ //TODO: https://github.com/jackalope/jackalope-doctrine-dbal/issues/15
'Query\\QuerySql2OperationsTest::testQueryJoin',
'Query\\QuerySql2OperationsTest::testQueryJoinReference',
@@ -55,35 +53,33 @@ protected function __construct()
// https://github.com/phpcr/phpcr-api-tests/issues/22
'Query\\NodeViewTest::testSeekable',
- 'Writing\\AddMethodsTest::testAddNodeIllegalType',
- 'Writing\\AddMethodsTest::testAddNodeInParallel',
- 'Writing\\AddMethodsTest::testAddPropertyWrongType',
- 'Writing\\CopyMethodsTest::testCopyUpdateOnCopy',
- 'Writing\\CopyMethodsTest::testWorkspaceCopy',
+ 'Writing\\AddMethodsTest::testAddNodeIllegalType', //TODO: https://github.com/jackalope/jackalope-doctrine-dbal/issues/16
+ 'Writing\\AddMethodsTest::testAddNodeInParallel', //TODO: https://github.com/jackalope/jackalope-doctrine-dbal/issues/17
+ 'Writing\\AddMethodsTest::testAddPropertyWrongType', //TODO: https://github.com/jackalope/jackalope-doctrine-dbal/issues/18
+ 'Writing\\CopyMethodsTest::testCopyUpdateOnCopy', //TODO: update-on-copy is currently not supported
+ 'Writing\\CopyMethodsTest::testWorkspaceCopy', //TODO: https://github.com/jackalope/jackalope-doctrine-dbal/issues/19
'Writing\\MoveMethodsTest::testSessionDeleteMoved', // TODO: enable and look at the exception you get as starting point
- 'Writing\\MoveMethodsTest::testNodeOrderBeforeEnd',
- 'Writing\\MoveMethodsTest::testNodeOrderBeforeDown',
- 'Writing\\MoveMethodsTest::testNodeOrderBeforeUp',
- 'Writing\\DeleteMethodsTest::testRemoveNodeConstraintViolation',
- 'Writing\\DeleteMethodsTest::testNodeRemovePropertyConstraintViolation',
+ 'Writing\\DeleteMethodsTest::testRemoveNodeConstraintViolation', //TODO: https://github.com/jackalope/jackalope-doctrine-dbal/issues/20
+ 'Writing\\DeleteMethodsTest::testNodeRemovePropertyConstraintViolation', //TODO: https://github.com/jackalope/jackalope-doctrine-dbal/issues/21
+
+ //TODO: moving nodes is not implemented yet
'Writing\\CombinedManipulationsTest::testRemoveAndMove',
'Writing\\CombinedManipulationsTest::testAddAndChildAddAndMove',
'Writing\\CombinedManipulationsTest::testMoveSessionRefreshKeepChanges',
- 'Transactions\\TransactionMethodsTest::testInTransaction',
+ //TODO: https://github.com/jackalope/jackalope-doctrine-dbal/issues/22
'Transactions\\TransactionMethodsTest::testTransactionCommit',
- 'Transactions\\TransactionMethodsTest::testTransactionRollback',
+ //TODO: Client::createWorkspace throws a NotImplementedException
'WorkspaceManagement\\WorkspaceManagementTest::testCreateWorkspaceWithSource',
'WorkspaceManagement\\WorkspaceManagementTest::testCreateWorkspaceWithInvalidSource',
'WorkspaceManagement\\WorkspaceManagementTest::testDeleteWorkspace',
- //some import tests are skipped for now, issue opened: https://github.com/jackalope/jackalope-doctrine-dbal/issues/12
+ //TODO: https://github.com/jackalope/jackalope-doctrine-dbal/issues/12
'Import\\ImportRepositoryContentTest::testImportXMLUuidReplaceExistingWorkspace',
'Import\\ImportRepositoryContentTest::testImportXMLUuidReplaceExistingSession',
'Import\\ImportRepositoryContentTest::testImportXMLUuidReplaceRoot',
);
-
}
public static function getInstance()
Something went wrong with that request. Please try again.