DoctrineDBALImplementationLoader review with the current application state #23

Merged
merged 3 commits into from Apr 27, 2012

Conversation

Projects
None yet
3 participants
@adou600
Contributor

adou600 commented Apr 20, 2012

All the skipped tests in DoctrineDBALImplementationLoader.php have been commented (with the corresponding issue) or have been removed if no error were thrown.

@@ -14,22 +14,16 @@ protected function __construct()
parent::__construct('Jackalope\RepositoryFactoryDoctrineDBAL', $GLOBALS['phpcr.workspace']);
$this->unsupportedChapters = array(

This comment has been minimized.

@dbu

dbu Apr 23, 2012

Member

please keep ShareableNodes, AccessControlManagement, LifecycleManagement, RetentionAndHold, SameNameSiblings in the list of things to skip. the reason you can currently remove them without failure is that there are no tests implemented for them.

@dbu

dbu Apr 23, 2012

Member

please keep ShareableNodes, AccessControlManagement, LifecycleManagement, RetentionAndHold, SameNameSiblings in the list of things to skip. the reason you can currently remove them without failure is that there are no tests implemented for them.

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Apr 25, 2012

This pull request passes (merged ef7c2c3 into 6baac30).

This pull request passes (merged ef7c2c3 into 6baac30).

@travisbot

This comment has been minimized.

Show comment
Hide comment
@travisbot

travisbot Apr 27, 2012

This pull request passes (merged f4efd91 into 8af1b8a).

This pull request passes (merged f4efd91 into 8af1b8a).

dbu added a commit that referenced this pull request Apr 27, 2012

Merge pull request #23 from adou600/unskip-tests
DoctrineDBALImplementationLoader review with the current application state

@dbu dbu merged commit abdc4b4 into jackalope:master Apr 27, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment