Skip to content

/ jack2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance promiscuous mode #77

Closed
wants to merge 1 commit into from
Closed

Enhance promiscuous mode #77

wants to merge 1 commit into from

Conversation

@sdrik
Copy link
Contributor

@sdrik sdrik commented Nov 2, 2014

No description provided.

@sdrik sdrik mentioned this pull request Nov 2, 2014
Closed
@adiknoth
Copy link
Member

@adiknoth adiknoth commented Apr 15, 2015

Was there a discussion about this pull request?

I definitely like the first patch about audio reservation. I'm less sure about the 2nd, I feel the implementation could be easier.
@adiknoth
Copy link
Member

@adiknoth adiknoth commented Apr 15, 2015

I've merged the first commit.
@sdrik sdrik force-pushed the sdrik:pull/promiscuous-v1 branch from 03eb5b8 to 01106ef Apr 27, 2015
@sdrik sdrik mentioned this pull request Apr 28, 2015
Merged
@adiknoth
Copy link
Member

@adiknoth adiknoth commented Mar 12, 2017

This PR no longer cleanly applies. If you still care about it, please rebase and ping the thread so that we can merge promptly.
@sdrik
Allow setting group/permissions of filesystem objects in promiscuous …
8a19dc8 
…mode

If the value of the JACK_PROMISCOUS_SERVER environment variable is set to the
name or gid of a valid UNIX group for the current user, then all filesystem
objects (e.g. sockets, semaphores and shared memory segments) will be created
with this group as owner, and the permissions will be set to 0660. If not, the
permissions will be set to 0666.
This remove the requirement to use a way too permissive umask for promiscuous
mode to work properly.
For that purpose, a new jack_group2gid helper function has been introduced in
its own obj file so it can be called from both C and C++ code.
@sdrik sdrik force-pushed the sdrik:pull/promiscuous-v1 branch from 01106ef to 8a19dc8 Mar 13, 2017
@sdrik
Copy link
Contributor Author

@sdrik sdrik commented Mar 13, 2017

The PR has been rebased onto current master.
@falkTX
Copy link
Member

@falkTX falkTX commented Mar 13, 2017

Please note that latest git no longer uses JackPosixSemaphore.cpp/h in linux builds.
@sdrik
Copy link
Contributor Author

@sdrik sdrik commented Mar 13, 2017

Thanks for the heads up. I'll look into this asap.
@falkTX
Copy link
Member

@falkTX falkTX commented Mar 13, 2017 •
edited

I don't think some of that code will compile under OSX, specially sysconf stuff...
Since you use a macro test for __linux__ under the semaphore code, I suggest adding the same __linux__ check in gid.c
@sdrik sdrik mentioned this pull request Mar 18, 2017
Merged
@sdrik
Copy link
Contributor Author

@sdrik sdrik commented Mar 18, 2017

Closing this one. See #257 for a reworked version.
@sdrik sdrik closed this Mar 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge conflict
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@sdrik @adiknoth @falkTX