Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix operation reply to last treated client instead to reply to sender #21

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

Houston4444
Copy link
Contributor

@Houston4444 Houston4444 commented Jun 24, 2020

Hi.

These PR fixes major problem with :server_control: capability : the server replies that the operation was made to the last client processed rather than to the sender.
This is related to this issue : https://github.com/original-male/non/issues/254

Here I only fixed the issue for main operations : new, open, save, duplicate, close, abort.
There was a weird indentation in 'abort', so I fixed it.
I also fixed the wrong reply of 'add' operation.

I could go a little further, but here it needs to take decisions.

At end of OSC_HANDLER( list) , the actual reply is wrong for sure, '/reply' or '/error' is missing.
I see 2 choices:

osc_server->send( lo_message_get_source( msg ), '/error', path, ERR_OK, "List done." );
or
osc_server->send(lo_message_get_source( msg ), '/reply', '');

I've got a preference for the second one, because it's not an error and a session can not have no name.

in OSC_HANDLER( quit ), do you agree that we should answer right before we shutdown the daemon?
Factually daemon should informs GUI that is quitting, it probably needs one more OSC message in GUI.

@diovudau diovudau merged commit d4b9c69 into jackaudio:master Jun 24, 2020
@diovudau
Copy link
Contributor

Thank you very much.

@diovudau
Copy link
Contributor

For the logbook:

  • A decision for OSC_HANDLER( quit ) was postponed until it is clear if multiple GUIs are feasable in principle
  • From the original issue, this will hopefully addresses when fixing the lockfiles
    • load_session_file , line 1193: if session's folder doesn't exists, it answers "/error ERR_SESSION_LOCKED session is locked by another process.".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants