Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is a toast? #26

Closed
edent opened this issue Jun 13, 2019 · 4 comments

Comments

Projects
None yet
4 participants
@edent
Copy link

commented Jun 13, 2019

Please could you explain what a "toast" is - and provide some sample screenshots?

At the moment, the spec reads like it is alert("I'm a toast!); which I don't think is your intention.

Juding from a Twitter thread, I'm not alone in this confusion. https://twitter.com/stevefaulkner/status/1138933155866513409

I always associate Toasts with those annoying Android popups which mysteriously appear and disappear. Again, I'm not quite sure if that's what you're going for. Some mockups or screenshots would help clarify.

@monico-moreno

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

fyi 👉 #30 😉

@edent

This comment has been minimized.

Copy link
Author

commented Jun 13, 2019

@domenic I didn't see those linked from the readme. GitHub's colour scheme isn't great on mobile - so I didn't spot any links. That's why I suggested screenshots on the "front page".

@aardrian

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

I see the PR to address this.

However, even that refined definition of toast leans on a visual metaphor. It is meaningless to many users and for others implies or asserts a kind of interaction as necessary.

Just as many developers choose an <h2> over a more appropriate <h4> because they want bolder, bigger text, developers may choose this new element based on how it moves or where it lives on the screen instead of by the features it brings.

Suggest defining toast using the existing roles already specced in ARIA (see #25 ) and naming it based on a word that captures those roles. Which means before proposing a proper name, agreeing on the roles, which means defining the problem as a user need not a developer need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.