Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add definition of toast, using quotes, etc. #30

Merged
merged 6 commits into from Jun 14, 2019

Conversation

Projects
None yet
4 participants
@monico-moreno
Copy link
Contributor

commented Jun 13, 2019

Given questions like in issue #26, added a definition to the readme to address these questions from the community.

@monico-moreno monico-moreno referenced this pull request Jun 13, 2019

Closed

What is a toast? #26

@domenic

This comment has been minimized.

Copy link
Collaborator

commented Jun 13, 2019

This is great, thank you! Do you think maybe the last paragraph should reference the libraries researched in https://github.com/jackbsteinberg/std-toast/blob/master/study-group/ ?

@monico-moreno

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

You're welcome! 😊

Changes made to reference the study group page. 👍

@domenic

This comment has been minimized.

Copy link
Collaborator

commented Jun 13, 2019

@edent, does this help? In my opinion, we should merge this to close #26 and make it clearer what the repository is about, but open a new issue to discuss whether "toast" is the best name. How does that sound to you?

README.md Outdated
Furthermore, Ben Brocka has a nice, concise definition, in his [ux.stackexchange.com response](https://ux.stackexchange.com/a/12000), _"A Toast is a non modal, unobtrusive window element used to display brief, auto-expiring windows of information to a user."_, which adds the distinguishing detail of a toast's being **auto-expiring**.

In the absence of browser-intrinsic toasts, the current state of affairs is that libraries like Bootstrap include [toast features like this one](https://getbootstrap.com/docs/4.2/components/toasts/). Additionally, here is the Toast Study Group's [list of 3rd party libraries](https://github.com/jackbsteinberg/std-toast/tree/master/study-group) that includes an awesome table of comparison.

This comment has been minimized.

Copy link
@mkruisselbrink

mkruisselbrink Jun 13, 2019

calling your own study "awesome" seems a bit pretentious, and it also doesn't seem like including that words adds anything to the sentence? (it's also not clear to me who or what the "Toast Study Group" is)

This comment has been minimized.

Copy link
@domenic

domenic Jun 13, 2019

Collaborator

Thanks for pointing this out. Notice that this was written by a third-party contributor---thanks @monico-moreno for the compliment! But yeah, I'll touch it up before merging.

This comment has been minimized.

Copy link
@monico-moreno

monico-moreno Jun 13, 2019

Author Contributor

You're welcome, @domenic. Good catch, @mkruisselbrink. I will, however, leave the question as to what the Toast Study Group is to the experts. Perhaps a link to a description segment or page? 🤔

@edent

This comment has been minimized.

Copy link

commented Jun 13, 2019

As you have screenshots, it would be great to include them on the readme. I realise the plural of anecdote is not data, but I had no idea what this was talking about until I saw images.

I'd suggest testing this readme with a few people unfamiliar with the nomenclature to see how else it can be approved.

@domenic

This comment has been minimized.

Copy link
Collaborator

commented Jun 13, 2019

Yeah, we've definitely heard the message loud and clear from the community on this. We'd so far only spoken to UI engineers or people who work on design systems, who were quite familiar; with the broader audience, we need to make things clearer.

@monico-moreno

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

@domenic , @edent I added an animated gif that shows what a typical look-and-feel would be like.

monico-moreno and others added some commits Jun 13, 2019

Small tweaks
- Use blockquotes for quotes
- Use semantic line breaking
- Use an existing demo GIF
- Add alt text to the image
@domenic

This comment has been minimized.

Copy link
Collaborator

commented Jun 14, 2019

Thank you so much @monico-moreno! I made some minor tweaks and will now merge this, then file a follow-up issue for folks to discuss naming.

@domenic domenic merged commit 2e01dd1 into jackbsteinberg:master Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.