Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced emoji with yes/no #32

Merged
merged 2 commits into from Jun 14, 2019

Conversation

Projects
None yet
2 participants
@aardrian
Copy link
Contributor

commented Jun 13, 2019

The emoji announce in screen readers as "X, graphic" or "white underscore check underscore mark, graphic" (TalkBack) or "crossmark" or "white heavy checkmark" (NVDA). In Android Chrome, the emoji for the checkmark is white, no green box as you might see on Windows. This will read faster and not have the contrast issue. I would prefer blanks instead of "no", but am not sure if you have a third value for unknown and don't want to mess with that.

Screen shots are from Chrome / Android.

Red X:
Screenshot_20190613-145011~2

White check:
Screenshot_20190613-143841~2

Replaced emoji with yes/no
The emoji announce in screen readers as "X, graphic" or "white underscore check underscore mark, graphic" (TalkBack) or "crossmark" or "white heavy checkmark" (NVDA). In Android Chrome, the emoji for the checkmark is white, no green box as you might see on Windows. This will read faster and not have the contrast issue.  I would prefer blanks instead of "no", but am not sure if you have a third value for unknown and don't want to mess with that.
@domenic

This comment has been minimized.

Copy link
Collaborator

commented Jun 14, 2019

Thanks so much! I think blanks instead of no makes sense as well, so I'll tweak that and then merge.

@domenic domenic merged commit 8b2c7bf into jackbsteinberg:master Jun 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.