Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature compound lens #15 #93

Merged
merged 3 commits into from
Jul 10, 2015
Merged

Feature compound lens #15 #93

merged 3 commits into from
Jul 10, 2015

Conversation

jackfirth
Copy link
Owner

Closes #15 and #84 and creates an unstable/lens module for more additions

jackfirth added a commit that referenced this pull request Jul 10, 2015
@jackfirth jackfirth merged commit 13bc0ed into master Jul 10, 2015
@jackfirth jackfirth deleted the feature-compound-lens-#15 branch July 10, 2015 06:33
@AlexKnauth
Copy link
Collaborator

Is compound-list-lens the best name for this? The word compound makes me think of nested lenses produced by lens-compose or lens-thrush.

Would something like mapped-list-lens be a better name, or?

@jackfirth
Copy link
Owner Author

I generally think of compound lenses as any lens created by combining two or more other lenses, but it may be good to describe the difference between combining lenses in series (compose and thrush) vs in parallel (compound list and hash)

@jackfirth
Copy link
Owner Author

Or an entire subcollection lens/compound that contains compose, thrush, and this combinator

@jackfirth jackfirth mentioned this pull request Jul 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants