Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove list->multiset #261

Merged
merged 2 commits into from Oct 9, 2019

Conversation

@campbellr
Copy link
Contributor

commented Oct 8, 2019

This PR addresses #252.

The first commit replaces all calls to list->multiset with sequence->multiset, the second commit removes the definition, tests, and docs for list->multiset.

This is my first Racket-related PR so I welcome any feedback.

Let me know if there are any other code or doc changes needed (eg: notice about breaking backwards-compatibility etc...)

Copy link
Owner

left a comment

Looks great! I left a minor comment, but other than that this is good to merge. Thank you very much for the pull request.

private/association-list.rkt Outdated Show resolved Hide resolved
@campbellr campbellr force-pushed the campbellr:remove-list-multiset branch from 9b96f0e to 050125d Oct 9, 2019
Copy link
Owner

left a comment

Great work! Merging

@jackfirth jackfirth merged commit 7066505 into jackfirth:master Oct 9, 2019
1 check passed
1 check passed
racket-package-ci
Details
@jackfirth jackfirth referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.