Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird behaviour when running pulldown marionette #76

Open
jackfranklin opened this issue Sep 8, 2013 · 11 comments
Open

Weird behaviour when running pulldown marionette #76

jackfranklin opened this issue Sep 8, 2013 · 11 comments
Labels

Comments

@jackfranklin
Copy link
Owner

public/javascripts/lib > pulldown marionette 
-> Success: https://cdnjs.cloudflare.com/ajax/libs/underscore.js/1.5.1/underscore-min.js was downloaded to ./underscore-min.js
-> Success: https://cdnjs.cloudflare.com/ajax/libs/backbone.js/1.0.0/backbone-min.js was downloaded to ./backbone-min.js
-> Success: https://cdnjs.cloudflare.com/ajax/libs/jquery/2.0.3/jquery.min.js was downloaded to ./jquery.min.js
-> Success: https://cdnjs.cloudflare.com/ajax/libs/backbone.marionette/1.1.0-bundled/backbone.marionette.min.js was downloaded to ./backbone.marionette.min.js

it grabs backbone set too?!

@tgvashworth
Copy link
Collaborator

Yep, I added it as a set.

@jackfranklin
Copy link
Owner Author

Ah nice, fair enough.

I wonder if to make this clearer, there should be an additional line of terminal output:

pulldown marionette
-> Pulldown found set "marionette": backbone, backbone.marionette
-> Success: .....
...

Perhaps?

@tgvashworth
Copy link
Collaborator

Hmm. That's a tricky one, because it all resolves itself inside pulldown-resolve (I think). Worth thinking about tho.

@jackfranklin
Copy link
Owner Author

Ah of course, yes. Hmm.

@jackfranklin
Copy link
Owner Author

@PhUU it would be good to revisit this and have a think about if it's possible...

@tgvashworth
Copy link
Collaborator

The obvious way would be to hit the api endpoint for a particular set to see what you get back, but in the case of marionette it would be:

[ "backbone", "backbone.marionette" ]

Which ain't much use. But it's more useful than nothing, eh?

The next step would be to partially resolve the identifier, util just before it becomes a URL. But it's kinda the point of pulldown that it just deals in URLs – the resolving, API and set stuff is convenience.

@jackfranklin
Copy link
Owner Author

But the fact that the length > 1 tells you it's a set, right? So that would be enough to at least output "OMG SETTT"?

@tgvashworth
Copy link
Collaborator

Oh I just re-read what you said. Yes, we can defo do that. Just make the CLI hit the API. ALL THE ACRONYMS.

@jackfranklin
Copy link
Owner Author

Cool, I'll work on this sometime soon :)

@tgvashworth
Copy link
Collaborator

Result of chat elsewhere is to make pulldown-resolve and pulldown EventEmitters, then emit resolve events (or something) that the CLI can react to.

@jackfranklin
Copy link
Owner Author

+1. Let's get that nailed and then we can revisit this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants