Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement additional handling of events, slots, and situation-specific formatting #3

Closed
jackkoppa opened this issue Jan 6, 2020 · 0 comments · Fixed by #4
Closed

Implement additional handling of events, slots, and situation-specific formatting #3

jackkoppa opened this issue Jan 6, 2020 · 0 comments · Fixed by #4
Assignees

Comments

@jackkoppa
Copy link
Owner

@jackkoppa jackkoppa commented Jan 6, 2020

Remaining work before plugin covers primary known externally available options on components:

  • Event handling, with @event="handleEvent" syntax
  • Slots, including a default slot, non-default slots, and scoped slots with bindings
  • Appropriate casing for props (follow styleguide-recommended kebab-case)
  • Correct formatting when no props/events/slots, when only props, when only slots, etc.

After these are covered, a 1.0 release seems appropriate

@jackkoppa jackkoppa self-assigned this Jan 6, 2020
jackkoppa added a commit that referenced this issue Jan 6, 2020
…g for all cases

All known 'external' options of Vue components now supported (props, events, slots),
with appropriate formatting for various cases (e.g. only props, only slots, props + events, props + events + slots, etc.)
Going forward, tweaks to exported, parsed code will hopefully center around preference discussions & anything missed from Vue's styleguide
In the future, there may be a need for configurable CLI plugins, if certain teams have certain preferences, though that seems fairly distant
jackkoppa added a commit that referenced this issue Jan 6, 2020
jackkoppa added a commit that referenced this issue Jan 6, 2020
Since we're already using ':' instead of 'v-bind:', seems appropriate to prefer '#' over 'v-slot:'
@jackkoppa jackkoppa closed this in #4 Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.