Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement parsing for events & slots; improve formatting across cases #4

Merged
merged 7 commits into from Jan 6, 2020

Conversation

@jackkoppa
Copy link
Owner

jackkoppa commented Jan 6, 2020

Closes #3, and should allow for a 1.0.0 release

馃榾

jackkoppa added 6 commits Jan 6, 2020
鈥 for all cases

All known 'external' options of Vue components now supported (props, events, slots),
with appropriate formatting for various cases (e.g. only props, only slots, props + events, props + events + slots, etc.)
Going forward, tweaks to exported, parsed code will hopefully center around preference discussions & anything missed from Vue's styleguide
In the future, there may be a need for configurable CLI plugins, if certain teams have certain preferences, though that seems fairly distant
Since we're already using ':' instead of 'v-bind:', seems appropriate to prefer '#' over 'v-slot:'
@jackkoppa

This comment has been minimized.

Copy link
Owner Author

jackkoppa commented Jan 6, 2020

Quick example demonstrating some of the changes

Button, Previous

example_snippet

Button, New (notice prop casing, event handling, default slot, formatting)

Screen Shot 2020-01-06 at 4 21 16 PM

@simple-event=\\"handleSimpleEvent\\"
>
<!-- content -->
<template #simpleSlot=\\"slotBinding\\"></template>

This comment has been minimized.

Copy link
@jackkoppa
@jackkoppa jackkoppa merged commit 3d8258a into master Jan 6, 2020
@jackkoppa jackkoppa deleted the feature/finalize-supported-options branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.