Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed 859 of 1213 bytes from logo #6

Merged
merged 1 commit into from Jul 17, 2018

Conversation

Projects
None yet
2 participants
@mshaw42
Copy link

mshaw42 commented Jul 12, 2018

Inspired by your project I thought I might make a contribution, for the first time ever on Github.

I have reworked the logo to shave 859 bytes, this is with no loss of image fidelity. I believe a further 50 or so bytes can be saved by using integers rather than floating point numbers with marginal loss of quality. I don't think people would notice. However, since this is my first ever pull request I thought that getting the file down to 354 bytes would be a good start.

To go even lower I would recommend placing the SVG in the stylesheet and using a pseudo element to show the logo. This means that on subsequent page loads the logo is already there in the CSS and does will not need to be part of each and every document.

Furthermore, by using this approach you can keep 'decoration' out of the markup. You can also ensure that there is no javascript requirement to inline load the SVG.

@jacklenox

This comment has been minimized.

Copy link
Owner

jacklenox commented Jul 17, 2018

@mshaw42 This. Is. Amazing. Thank you so much. You have totally blown my mind with this.

I had already been looking into the merits of loading it in a way in which it can be cached, rather than included in the body of the page.

In a very pedantic manner, I have noticed a very slight discrepancy between your rewrite of the logo, and the original one. The difference is so minor that I'm still totally happy merging this, but I do just want to record it here for posterity. To me at least, the manual rewrite appears to have a slightly lighter stroke.

The original:

screenshot_2018-07-18 susty wp just another wordpress site

The manual rewrite:

screenshot_2018-07-18 susty wp just another wordpress site 1

@jacklenox jacklenox merged commit c3c4c1b into jacklenox:master Jul 17, 2018

@mshaw42

This comment has been minimized.

Copy link
Author

mshaw42 commented Sep 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.