Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added couple of filters and actions on notification and engine files #2

Closed
wants to merge 2 commits into from

Conversation

@g-kanoufi
Copy link

commented Oct 31, 2017

Hi Jack, as we talked about those are the small changes i needed for convenience while developing an addon for your awesome plugin.

I guess i might not want to add all the changes in that case i'll keep my fork merged with your updates.

Let me know what you think.

Cheers,

Guillaume

@jackmcconnell

This comment has been minimized.

Copy link
Owner

commented Dec 20, 2017

@g-kanoufi,
If you resolve the merge conflicts from the latest version of BNFW, I'll add this in the next version.

@g-kanoufi

This comment has been minimized.

Copy link
Author

commented Dec 22, 2017

@jackmcconnell done, thanks you.

@jackmcconnell

This comment has been minimized.

Copy link
Owner

commented Jan 9, 2018

@g-kanoufi This merge will show in the next version of BNFW.

@g-kanoufi

This comment has been minimized.

Copy link
Author

commented Jan 11, 2018

@jackmcconnell, awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.