Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call helm-make-source directly #400

Merged
merged 1 commit into from Jun 21, 2021
Merged

Call helm-make-source directly #400

merged 1 commit into from Jun 21, 2021

Conversation

psibi
Copy link
Contributor

@psibi psibi commented Jun 21, 2021

Avoids macro expansion issues if Helm is not yet loaded.

Fixes issue in environment like NixOS. Fixes #224

Avoids macro expansion issues if Helm is not yet loaded.

Fixes issue in environment like NixOS. Fixes jacktasia#224
@psibi
Copy link
Contributor Author

psibi commented Jun 21, 2021

Tested that the CI pases fine in my fork. And this change seems to have fixed it in my NixOS setup.

@jacktasia jacktasia requested a review from phikal June 21, 2021 16:36
@jacktasia
Copy link
Owner

Thanks for opening this! This lgtm, but curious what @phikal thinks

@phikal
Copy link
Contributor

phikal commented Jun 21, 2021

I'm not familiar with Helm, so I cannot say much. Could @psibi explain what the issue specifically with NixOS is in more detail?

@psibi
Copy link
Contributor Author

psibi commented Jun 21, 2021

@phikal This was what was happening in NixOS:

This is my configuration:

(use-package dumb-jump
  :ensure t
  :bind (("M-g o" . dumb-jump-go-other-window)
         ("M-g b" . dumb-jump-back))
  :config (progn
            (setq dumb-jump-selector 'helm)
            (setq dumb-jump-force-searcher 'rg)))

Steps to reproduce:

  • I invoke dumb-jump-go-other-window and it doesn't do anything
  • In the Messages buffers, I get this message:
dumb-jump-prompt-user-for-choice: Invalid function: helm-build-sync-source

A quick google suggests that this is a issue in Nix systems: alphapapa/org-ql#60 (comment)

I applied the same fix of org-ql in dumb-jump and it started working fine for me. Also it seems other nix users of dumb-jump are facing the same issue: #224 (comment) Unfortunately, I didn't dig more deeply to find more about the issue.

@phikal
Copy link
Contributor

phikal commented Jun 21, 2021

I'm going to assume there are no downsides to this, so I don't see any reason to object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid function helm-build-sync-source
3 participants