From 09850f479d9ca4f94b545da41b3284ce8823380a Mon Sep 17 00:00:00 2001 From: jack Date: Mon, 8 Aug 2016 16:17:51 -0700 Subject: [PATCH 1/2] use region when there is a selection, closes #66 --- dumb-jump.el | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/dumb-jump.el b/dumb-jump.el index 49317fb..e6d62f2 100644 --- a/dumb-jump.el +++ b/dumb-jump.el @@ -672,7 +672,7 @@ denoter file/dir is found or uses dumb-jump-default-profile" (dumb-jump-fetch-shell-results)) ((buffer-modified-p (current-buffer)) (dumb-jump-issue-result "unsaved")) - ((not (thing-at-point 'symbol)) + ((and (not (region-active-p)) (not (thing-at-point 'symbol))) (dumb-jump-issue-result "nosymbol")) (t (dumb-jump-fetch-file-results)))) @@ -715,9 +715,11 @@ denoter file/dir is found or uses dumb-jump-default-profile" (defun dumb-jump-get-point-symbol () "Get symbol at point." - (if (version< emacs-version "24.4") - (thing-at-point 'symbol) - (thing-at-point 'symbol t))) + (if (region-active-p) + (buffer-substring-no-properties (region-beginning) (region-end)) + (if (version< emacs-version "24.4") + (thing-at-point 'symbol) + (thing-at-point 'symbol t)))) (defun dumb-jump-get-lang-by-shell-contents (buffer) "Return languages in BUFFER by checking if file extension is mentioned." From 45373491267d07b8c2ffabdfdb0d8f71a84e0b98 Mon Sep 17 00:00:00 2001 From: jack Date: Mon, 8 Aug 2016 16:34:05 -0700 Subject: [PATCH 2/2] dumb-jump-get-point-symbol-region-active-test --- test/dumb-jump-test.el | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/test/dumb-jump-test.el b/test/dumb-jump-test.el index fc2906d..5b10676 100644 --- a/test/dumb-jump-test.el +++ b/test/dumb-jump-test.el @@ -176,6 +176,14 @@ (expected (f-expand dumb-jump-default-project))) (should (string= found-project expected))))) +(ert-deftest dumb-jump-get-point-symbol-region-active-test () + (with-mock + (mock (region-active-p) => t) + (mock (region-beginning) => 0) + (mock (region-end) => 1) + (mock (buffer-substring-no-properties * *) => "blah") + (dumb-jump-get-point-symbol))) + (ert-deftest dumb-jump-goto-file-line-test () (let ((js-file (f-join test-data-dir-proj1 "src" "js" "fake.js"))) (with-mock