New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve server logging, tidy code #522

Merged
merged 3 commits into from Oct 4, 2018

Conversation

Projects
None yet
2 participants
@bls1999
Contributor

bls1999 commented Aug 12, 2018

The main focus of this pull is to tidy the output when it comes to logging things in server logs. This just makes messages easier to understand if you're trying to debug something that happened.

Technical details:

  • restart_server: add sleep(1) between shutdown and start
  • test_server: delegate to restart_server
  • start_server: tidy code and log output
  • shut_down_server: more accurate logging
  • get_pid_file: tidy code
  • read_pid: tidy code and log output

Also:

  • Added admin name on server restart to the log (Player.php)
  • Fixed a typo in Game.php (appyExpCurve -> applyExpCurve; sorry, couldn't resist)

With that, I believe every typo in the repo is gone. It was not an easy journey. We have come far since January.

bls1999 added some commits Aug 12, 2018

tidy socket fns
 - restart_server: add sleep(1) between shutdown and start
 - test_server: delegate to restart_server
 - start_server: tidy code and log output
 - shut_down_server: more accurate logging
 - get_pid_file: tidy code
 - read_pid: tidy code and log output

@bls1999 bls1999 changed the title Refine server logging, improve reliability Refine server logging, improve reporting reliability Aug 12, 2018

fix typo
This was bugging me. appyExpCurve -> applyExpCurve

@bls1999 bls1999 changed the title Refine server logging, improve reporting reliability Improve server logging Aug 12, 2018

@bls1999 bls1999 changed the title Improve server logging Improve server logging, tidy code Aug 13, 2018

@jacob-grahn jacob-grahn merged commit 127e7b3 into jacob-grahn:master Oct 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bls1999 bls1999 deleted the bls1999:tidy-socket-fns branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment