Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithreaded Lock during deserialization - (describes fix) #172

Open
gjroelofs opened this issue Nov 7, 2022 · 0 comments
Open

Multithreaded Lock during deserialization - (describes fix) #172

gjroelofs opened this issue Nov 7, 2022 · 0 comments

Comments

@gjroelofs
Copy link

if (_cachedAttributeQueries.TryGetValue(query, out attribute) == false) {

For anyone else that is trying to debug lock ups during mass load scenarios; this line is not multithreading safe (as well as FullInspector's InspectedType.Caching.cs acces on _cachedMetadata) which causes issues when Unity starts to multithread Behaviour/ScriptableObject deserialization.

Both the static caches need to be locked on to fix this issue.

@gjroelofs gjroelofs changed the title Multithreaded Lock during deserialization Multithreaded Lock during deserialization - (describes fix) Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant