Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Processing of sub directories are not performed correctly with Windows #95
Thanks for contributing. Can you explain in more details what problem this is solving and how? I'm a little unclear from the summary and from the diff.
Also the code currently removes the filename from the array whereas your patch now keeps the filename. Is this intentional?
For example, I will source file has are as follows.
If normal operation, the menu should look like this.
However, the link is not in the drop-down menu like this image on Windows.
I try to output of this code of cli.js in the "var parts".
The output will be like this.Please read the documentation of "path.relative()" for details.
Then, I try to output the code that I have changed.
The output will be like this.Please read the documentation of "path.dirname()" for details.
And, you can if you remove directory name of the source file to "css" using
I'm sorry, but I do not know details about the unit test. Could you tell me what to do specifically?
It may be different from the one you are looking for, but the result of
Before making changes to the code :
After changing the code :
added a commit
this pull request
Sep 13, 2013
Ah, so in fact we already had a test documenting this behaviour and (as would be expected) it was failing in Windows. In that case there's nothing more to do. Pull request merged with thanks.
If you're interested, the unit test for this case can be found in test/cli.js