Ensure http urls are not replaced as part of urlsRelative #97

Merged
merged 3 commits into from Oct 7, 2013

Conversation

Projects
None yet
2 participants
@indieisaconcept
Contributor

indieisaconcept commented Oct 6, 2013

If url paths contain http(s):// urls these are also replaced. The change updates the regex to exclude these urls from matching.

Example: http://regex101.com/r/nC4aC2

@indieisaconcept indieisaconcept referenced this pull request in indieisaconcept/grunt-styleguide Oct 6, 2013

Closed

@import with full url() seems to add relative path and break #16

@indieisaconcept

This comment has been minimized.

Show comment
Hide comment
@indieisaconcept

indieisaconcept Oct 6, 2013

Contributor

I'll review the failing tests shortly.

Contributor

indieisaconcept commented Oct 6, 2013

I'll review the failing tests shortly.

indieisaconcept added some commits Oct 6, 2013

Updated tests
Tweak regex
Added test for data-uri also

marrs added a commit that referenced this pull request Oct 7, 2013

Merge pull request #97 from indieisaconcept/relativeURLS
Ensure http urls are not replaced as part of urlsRelative.

@marrs marrs merged commit 05e6950 into jacobrask:master Oct 7, 2013

1 check passed

default The Travis CI build passed
Details
@marrs

This comment has been minimized.

Show comment
Hide comment
@marrs

marrs Oct 7, 2013

Collaborator

Merged with thanks

Collaborator

marrs commented Oct 7, 2013

Merged with thanks

@indieisaconcept indieisaconcept deleted the indieisaconcept:relativeURLS branch Oct 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment