New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP mode #210

Open
CyberShadow opened this Issue Mar 4, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@CyberShadow

CyberShadow commented Mar 4, 2018

Hi, and thank you for your work on this project.

I'm trying to get PHP mode to work with the latest version from git, and running into some trouble.

  1. First, currently there is no documentation. The only instructions I found on this subject were in the changelog. This might not be a problem if integrating Hashover in PHP mode would be simple or obvious, but I haven't found such a way.

  2. Following the changelog instructions:

    You implement it like so:
    <?php
    $hashover = new HashOver ('php', 'title', 'URL');
    ?>
    <!DOCTYPE html>
    ...
    <div id="hashover">
    <?php
    echo $hashover->displayComments ();
    ?>
    </div>

    currently seems insufficient. It results in the error:

    <b>Fatal error</b>:  Uncaught TypeError: Argument 2 passed to HashOver\PHPMode::__construct() must be an instance of HashOver\CommentsUI, null given, called in /home/csblog/hashover-next/hashover/backend/classes/hashover.php on line 414 and defined in /home/csblog/hashover-next/hashover/backend/classes/phpmode.php:43
    Stack trace:
    #0 /home/csblog/hashover-next/hashover/backend/classes/hashover.php(414): HashOver\PHPMode-&gt;__construct(Object(HashOver\Setup), NULL, Array)
    #1 /home/csblog/www/hashovertest.php(22): HashOver-&gt;displayComments()
    #2 {main}
      thrown in <b>/home/csblog/hashover-next/hashover/backend/classes/phpmode.php</b> on line <b>43</b><br />
    
  3. From looking at the source code, I inferred that the above code is missing calls to $hashover->initiate() and $hashover->finalize(). Adding those, there are no more errors; however, the output looks like this:

    screen shot 2018-03-04 at 06 33 02

    • It looks like the form has many more fields than necessary.
    • There is a "Name" and "Password" field even though "Allow users to login" is off.
    • There is complete lack of styling. There are no references to style sheets in the generated HTML, either.

Have I missed something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment