New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MANIFEST file, so "make dist" will work #3

Merged
merged 1 commit into from May 18, 2017

Conversation

Projects
None yet
2 participants
@neilb
Contributor

neilb commented May 16, 2017

Hi Dave,

With this PR applied, you can then run:

perl Makefile.PL
make dist

And that will result in a tarball which includes both a META.yml and META.json. That will make life easier for a good number of tools. And will also mean that Expect will contribute to the CPAN River calculations, as code will be able to tie Expect to the dists that it relies on.

Best to make sure you've got the latest version of ExtUtils::MakeMaker installed first.

Also, I recommend that you rename the repo name to "Expect" rather than "expect.pm". This is the convention for CPAN dists on github. At first I couldn't find this repo, because I was looking for a repo called "Expect". But then I found you on github, and thus the "expect.pm".

Having renamed the repo, you should then update Makefile.PL, so the repository metadata refers to your repo, and not Gabor's.

Let me know if I can help in any way.

Cheers,
Neil

@neilb

This comment has been minimized.

Show comment
Hide comment
@neilb

neilb May 16, 2017

Contributor

I should have also said:

I bumped the version number ready for a release, and put that in Changes.
You'll need to set the date when you release in the Changes file.

Contributor

neilb commented May 16, 2017

I should have also said:

I bumped the version number ready for a release, and put that in Changes.
You'll need to set the date when you release in the Changes file.

@jacoby jacoby merged commit 1154d56 into jacoby:master May 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jacoby

This comment has been minimized.

Show comment
Hide comment
@jacoby

jacoby May 18, 2017

Owner

Thanks.

Owner

jacoby commented May 18, 2017

Thanks.

@jacoby

This comment has been minimized.

Show comment
Hide comment
@jacoby

jacoby May 18, 2017

Owner

I see MYMETA.yml exports:
author:
- unknown

Found the point explaining AUTHOR in https://metacpan.org/release/ExtUtils-MakeMaker but not where/how it's set.

Owner

jacoby commented May 18, 2017

I see MYMETA.yml exports:
author:
- unknown

Found the point explaining AUTHOR in https://metacpan.org/release/ExtUtils-MakeMaker but not where/how it's set.

@jacoby

This comment has been minimized.

Show comment
Hide comment
@jacoby

jacoby May 18, 2017

Owner

Or, is this a thing not to worry about?

Owner

jacoby commented May 18, 2017

Or, is this a thing not to worry about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment