New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Java 8 for jacoco-maven-plugin #1466
Require Java 8 for jacoco-maven-plugin #1466
Conversation
@marchof if you're agree with this change, then I'll finalize this PR by updating changelog |
@Godin I agree with this change! |
c5d0014
to
0b54115
Compare
0b54115
to
e66c9fd
Compare
Looks like this change has broken some of our oldest builds based on java 7 Normally called as org.jacoco:jacoco-maven-plugin:prepare-agent , without specifying version, now uses 0.8.11 instead of 0.8.10 Would this have happened anyway if the versioning used were semver? We are looking where exactly is decided what jacoco version is used |
According to https://semver.org/
😉 Your build got broken because
this is not normal - see https://maven.apache.org/guides/mini/guide-configuring-plugins.html
|
I see XD
I agree, it surprise me too. I guess that using semver wouldn't had made a difference? without specifying it would have started using 1.0.0 anyway? I have to check where the version to use was decided |
This change will