Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Java 8 for jacoco-maven-plugin #1466

Merged
merged 1 commit into from May 24, 2023

Conversation

Godin
Copy link
Member

@Godin Godin commented May 23, 2023

@Godin Godin added this to the 0.8.11 milestone May 23, 2023
@Godin Godin self-assigned this May 23, 2023
@Godin Godin added this to Implementation in Current work items via automation May 23, 2023
@Godin Godin requested a review from marchof May 23, 2023 09:43
@Godin
Copy link
Member Author

Godin commented May 23, 2023

@marchof if you're agree with this change, then I'll finalize this PR by updating changelog

@marchof
Copy link
Member

marchof commented May 23, 2023

@Godin I agree with this change!

@Godin Godin force-pushed the require_java_8_for_jacoco-maven-plugin branch from c5d0014 to 0b54115 Compare May 23, 2023 20:24
@Godin Godin moved this from Implementation to Review in Current work items May 23, 2023
@Godin Godin marked this pull request as ready for review May 23, 2023 20:25
@Godin Godin force-pushed the require_java_8_for_jacoco-maven-plugin branch from 0b54115 to e66c9fd Compare May 23, 2023 21:16
@marchof marchof merged commit 94779ca into jacoco:master May 24, 2023
22 checks passed
Current work items automation moved this from Review to Done May 24, 2023
@Godin Godin deleted the require_java_8_for_jacoco-maven-plugin branch May 24, 2023 05:37
@irbian
Copy link

irbian commented Oct 19, 2023

Looks like this change has broken some of our oldest builds based on java 7

Normally called as org.jacoco:jacoco-maven-plugin:prepare-agent , without specifying version, now uses 0.8.11 instead of 0.8.10

Would this have happened anyway if the versioning used were semver? We are looking where exactly is decided what jacoco version is used

@Godin
Copy link
Member Author

Godin commented Oct 19, 2023

Would this have happened anyway if the versioning used were semver?

According to https://semver.org/

Major version zero (0.y.z) is for initial development. Anything MAY change at any time.

😉


Your build got broken because

Normally called as org.jacoco:jacoco-maven-plugin:prepare-agent , without specifying version

this is not normal - see https://maven.apache.org/guides/mini/guide-configuring-plugins.html

Important Note: Always define the version of each plugin used to guarantee build reproducibility.

@irbian
Copy link

irbian commented Oct 19, 2023

initial development
image

I see XD

this is not normal - see https://maven.apache.org/guides/mini/guide-configuring-plugins.html

I agree, it surprise me too. I guess that using semver wouldn't had made a difference? without specifying it would have started using 1.0.0 anyway? I have to check where the version to use was decided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants