New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New API org.jacoco.core.tools #159

Merged
merged 2 commits into from Nov 16, 2013

Conversation

Projects
None yet
3 participants
@marchof
Member

marchof commented Nov 16, 2013

Create new API package org.jacoco.core.tools for high level tools shared by different JaCoCo integrations.

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive commented Nov 16, 2013

Java Code Coverage Tools » jacoco #155 SUCCESS
This pull request looks good
(what's this?)

* <code>reset==false</code>, <code>retryCount==0</code> and
* <code>retryDelay=1000</code>.
*/
public ExecDumpClient() {

This comment has been minimized.

@mfriedenhagen

mfriedenhagen Nov 16, 2013

Member

I would like to see another constructor with all arguments given to make them final instead of providing setters. The only advantage of using setters here is that you may not mix arguments unintentionally.

@mfriedenhagen

mfriedenhagen Nov 16, 2013

Member

I would like to see another constructor with all arguments given to make them final instead of providing setters. The only advantage of using setters here is that you may not mix arguments unintentionally.

This comment has been minimized.

@marchof

marchof Nov 16, 2013

Member

While I'm also a fan of immutable objects I prefer this solution here for the following reasons:

  • Avoid too many parameters for an constructor
  • provide out-of-the box default behavior
  • extensible API for additional attributes in future.
@marchof

marchof Nov 16, 2013

Member

While I'm also a fan of immutable objects I prefer this solution here for the following reasons:

  • Avoid too many parameters for an constructor
  • provide out-of-the box default behavior
  • extensible API for additional attributes in future.
@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive commented Nov 16, 2013

Java Code Coverage Tools » jacoco #156 SUCCESS
This pull request looks good
(what's this?)

@mfriedenhagen

This comment has been minimized.

Show comment
Hide comment
@mfriedenhagen

mfriedenhagen Nov 16, 2013

Member

I really like the ExecDumpClient as all socket related stuff is hidden. Looks fine to me.

Member

mfriedenhagen commented Nov 16, 2013

I really like the ExecDumpClient as all socket related stuff is hidden. Looks fine to me.

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof Nov 16, 2013

Member

@mfriedenhagen Thanks for reviewing this!

Member

marchof commented Nov 16, 2013

@mfriedenhagen Thanks for reviewing this!

marchof added a commit that referenced this pull request Nov 16, 2013

Merge pull request #159 from jacoco/issue-159
New API org.jacoco.core.tools

@marchof marchof merged commit 6a6317b into master Nov 16, 2013

1 check passed

default The Travis CI build passed
Details

@marchof marchof deleted the issue-159 branch Nov 16, 2013

@marchof marchof restored the issue-159 branch Nov 23, 2013

@marchof marchof deleted the issue-159 branch Nov 23, 2013

@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.