New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align skip conditions and messages and give reasons #171

Merged
merged 3 commits into from Dec 22, 2013

Conversation

Projects
None yet
1 participant
@mfriedenhagen
Member

mfriedenhagen commented Dec 17, 2013

Right now the reasons and messages are not consistent and do not help to explain always why stuff is skipped:

  • Some skip messages state again that JaCoCo emits them which should be clear because of context.
  • Skip because of skip property is set to true does not explain this.
  • Skip messages because of missing data file or or target/classes should always emit the complete file name of the thing missing.

mfriedenhagen added a commit that referenced this pull request Dec 22, 2013

Merge pull request #171 from jacoco/issue-171
Align skip conditions and messages and give reasons

@mfriedenhagen mfriedenhagen merged commit e8dc872 into master Dec 22, 2013

1 check passed

default The Travis CI build passed
Details

@mfriedenhagen mfriedenhagen deleted the issue-171 branch Dec 22, 2013

@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.