New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove signatures from instrumented JAR files #186

Merged
merged 1 commit into from Feb 22, 2014

Conversation

Projects
None yet
3 participants
@marchof
Member

marchof commented Feb 22, 2014

The instrument Ant task should remove signatures from JAR files as instrumentation breaks these signatures.

This behavior should be configurable with a new attribute removesignatures which defaults to true.

@ghost ghost assigned marchof Jan 21, 2014

@marchof marchof added this to the 0.6.5 milestone Feb 22, 2014

marchof added a commit that referenced this pull request Feb 22, 2014

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof Feb 22, 2014

Member

@Godin @mfriedenhagen Should this behaviour also be configurable for the instrument Maven goal? From my understanding the Maven goal would be used on class files only, right?

Member

marchof commented Feb 22, 2014

@Godin @mfriedenhagen Should this behaviour also be configurable for the instrument Maven goal? From my understanding the Maven goal would be used on class files only, right?

@mfriedenhagen

This comment has been minimized.

Show comment
Hide comment
@mfriedenhagen

mfriedenhagen Feb 22, 2014

Member

I will take a look this evening.
On Feb 22, 2014 10:32 AM, "Marc R. Hoffmann" notifications@github.com
wrote:

@Godin https://github.com/Godin @mfriedenhagenhttps://github.com/mfriedenhagenShould this behaviour also be configurable for the instrument Maven goal?
From my understanding the Maven goal would be used on class files only,
right?


Reply to this email directly or view it on GitHubhttps://github.com//pull/186#issuecomment-35798720
.

Member

mfriedenhagen commented Feb 22, 2014

I will take a look this evening.
On Feb 22, 2014 10:32 AM, "Marc R. Hoffmann" notifications@github.com
wrote:

@Godin https://github.com/Godin @mfriedenhagenhttps://github.com/mfriedenhagenShould this behaviour also be configurable for the instrument Maven goal?
From my understanding the Maven goal would be used on class files only,
right?


Reply to this email directly or view it on GitHubhttps://github.com//pull/186#issuecomment-35798720
.

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive commented Feb 22, 2014

Java Code Coverage Tools » jacoco #245 SUCCESS
This pull request looks good
(what's this?)

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof Feb 22, 2014

Member

@mfriedenhagen Thx! Please also feel free to add review comments.

Member

marchof commented Feb 22, 2014

@mfriedenhagen Thx! Please also feel free to add review comments.

@mfriedenhagen

This comment has been minimized.

Show comment
Hide comment
@mfriedenhagen

mfriedenhagen Feb 22, 2014

Member

@marchof: jacoco:instrument will only look into target/classes, so when you only use class files generated in your current Maven reactor using a full run ala mvn clean verify, this should not be a problem as Maven will use class files from target/classes instead of installed JARs.
However, when you use options like mvn --projects module_name --also-make clean verify, Maven might pick up installed JARs instead of using target/classes. And when you do wierd stuff like unpacking dependencies with the maven-dependency-plugin and add these classes as well as sources with the buildhelper-maven-plugin, there might be a problem (see https://github.com/mfriedenhagen/pastebin/tree/jacoco-with-sources-from-dependent-jars for an example).

All in all I do not think we have to adapt anything for Maven, people doing weird stuff may kust exclude META-INF/* from unpacking.

I compiled your PR successfully, so I will merge it.

Member

mfriedenhagen commented Feb 22, 2014

@marchof: jacoco:instrument will only look into target/classes, so when you only use class files generated in your current Maven reactor using a full run ala mvn clean verify, this should not be a problem as Maven will use class files from target/classes instead of installed JARs.
However, when you use options like mvn --projects module_name --also-make clean verify, Maven might pick up installed JARs instead of using target/classes. And when you do wierd stuff like unpacking dependencies with the maven-dependency-plugin and add these classes as well as sources with the buildhelper-maven-plugin, there might be a problem (see https://github.com/mfriedenhagen/pastebin/tree/jacoco-with-sources-from-dependent-jars for an example).

All in all I do not think we have to adapt anything for Maven, people doing weird stuff may kust exclude META-INF/* from unpacking.

I compiled your PR successfully, so I will merge it.

mfriedenhagen added a commit that referenced this pull request Feb 22, 2014

Merge pull request #186 from jacoco/issue-186
Remove signatures from instrumented JAR files

@mfriedenhagen mfriedenhagen merged commit 3750024 into master Feb 22, 2014

1 check passed

default The Travis CI build passed
Details

@mfriedenhagen mfriedenhagen deleted the issue-186 branch Feb 22, 2014

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof Feb 22, 2014

Member

@mfriedenhagen Ok, thanks for clarification!

Member

marchof commented Feb 22, 2014

@mfriedenhagen Ok, thanks for clarification!

@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.