New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub #44: (Regression) Agent Mojo should set empty property, if execution was skipped #192

Merged
merged 1 commit into from Feb 13, 2014

Conversation

Projects
None yet
3 participants
@renataogarcia
Contributor

renataogarcia commented Feb 12, 2014

This is a patch for a regression on GitHub #44 which doesn't seem to be working since 0.6.4 including 0.6.5-SNAPSHOT.

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof Feb 12, 2014

Member

@mfriedenhagen Can you please review this? Thx

Member

marchof commented Feb 12, 2014

@mfriedenhagen Can you please review this? Thx

@marchof marchof added the maven label Feb 12, 2014

@marchof marchof added this to the 0.6.5 milestone Feb 12, 2014

@mfriedenhagen

This comment has been minimized.

Show comment
Hide comment
@mfriedenhagen

mfriedenhagen Feb 13, 2014

Member

Local build ran successfully with JDK7 and Maven 3.1.1. I also ran mvn -pl jacoco-maven-plugin.test clean install with JDK5 and Maven 2.2.1, but this throw an error in it-report-nomatch, because the message is a bit different with Maven 2.2.1. Will adapt the verify Script.

Member

mfriedenhagen commented Feb 13, 2014

Local build ran successfully with JDK7 and Maven 3.1.1. I also ran mvn -pl jacoco-maven-plugin.test clean install with JDK5 and Maven 2.2.1, but this throw an error in it-report-nomatch, because the message is a bit different with Maven 2.2.1. Will adapt the verify Script.

mfriedenhagen added a commit that referenced this pull request Feb 13, 2014

Merge pull request #192 from renataogarcia/master
GitHub #44: (Regression) Agent Mojo should set empty property, if execution was skipped

@mfriedenhagen mfriedenhagen merged commit c4aef33 into jacoco:master Feb 13, 2014

1 check passed

default The Travis CI build passed
Details

mfriedenhagen added a commit that referenced this pull request Feb 13, 2014

mfriedenhagen added a commit that referenced this pull request Feb 13, 2014

Fix `it-report-nomatch` for Maven 2.2.1 as detected in #192.
This is compatible with Maven 3.1.1 and Maven 2.2.1.

@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.