New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user property for parameter "dataFile" of "report" mojo #322

Merged
merged 2 commits into from Jun 11, 2016

Conversation

Projects
None yet
5 participants
@Tunaki

This comment has been minimized.

Show comment
Hide comment
@Tunaki

Tunaki Apr 20, 2016

This issue was referenced in the Stack Overflow question How to configure JaCoCo maven plugin from command line.

Tunaki commented Apr 20, 2016

This issue was referenced in the Stack Overflow question How to configure JaCoCo maven plugin from command line.

@widgetpl

This comment has been minimized.

Show comment
Hide comment
@widgetpl

widgetpl Apr 20, 2016

+1
but for me would be nice to have user property for all configuration parameters of JaCoCo plugin stages as it would alllow to run them from command line.

widgetpl commented Apr 20, 2016

+1
but for me would be nice to have user property for all configuration parameters of JaCoCo plugin stages as it would alllow to run them from command line.

@luanzhu

This comment has been minimized.

Show comment
Hide comment
@luanzhu

luanzhu Jun 9, 2016

+1
This option is going to be very useful when the jacoco tcp server cannot be accessed directly from the mvn plug-in.

luanzhu commented Jun 9, 2016

+1
This option is going to be very useful when the jacoco tcp server cannot be accessed directly from the mvn plug-in.

@Godin Godin added this to the 0.7.8 milestone Jun 10, 2016

@Godin Godin self-assigned this Jun 10, 2016

@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Jun 10, 2016

Member

@widgetpl this is not that easy in case of properties whose values are not primitive, e.g. rules of check mojo, or even lists such as includes and excludes of report mojo, while it is easy in case of dataFile of report mojo. So instead of trying to climb a mountain using too general statement "all of them", let's do a baby steps and solve various cases separately, and especially that as of today there is not that much parameters, which cannot be specified from command-line.

Member

Godin commented Jun 10, 2016

@widgetpl this is not that easy in case of properties whose values are not primitive, e.g. rules of check mojo, or even lists such as includes and excludes of report mojo, while it is easy in case of dataFile of report mojo. So instead of trying to climb a mountain using too general statement "all of them", let's do a baby steps and solve various cases separately, and especially that as of today there is not that much parameters, which cannot be specified from command-line.

@widgetpl

This comment has been minimized.

Show comment
Hide comment
@widgetpl

widgetpl Jun 10, 2016

@Godin yes You are right, I am requiring too much and for me dataFile is enough for now as i had problem just with this parameter and when i wrote about rest of them i thought that it might be useful in future for someone ;)

widgetpl commented Jun 10, 2016

@Godin yes You are right, I am requiring too much and for me dataFile is enough for now as i had problem just with this parameter and when i wrote about rest of them i thought that it might be useful in future for someone ;)

@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Jun 10, 2016

Member

@widgetpl thank you for your understanding!

Member

Godin commented Jun 10, 2016

@widgetpl thank you for your understanding!

@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Jun 10, 2016

Member

@marchof could you please review?

Funny that fix is one line, while changes for integration test much bigger 😄

Member

Godin commented Jun 10, 2016

@marchof could you please review?

Funny that fix is one line, while changes for integration test much bigger 😄

@marchof marchof merged commit 209b27c into master Jun 11, 2016

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@marchof marchof deleted the issue-322 branch Jun 11, 2016

@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.