New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MBeanClient example #333

Merged
merged 1 commit into from Oct 1, 2015

Conversation

Projects
None yet
2 participants
@marchof
Member

marchof commented Sep 30, 2015

  • JavaDoc is outdated - there is no "mbean" output mode
  • IProxy:
    • method byte[] dump(boolean reset) should match corresponding method from IAgent, which is void dump(boolean reset)
    • method byte[] getExecutionData(boolean reset) should be added
    • to avoid such issues consider execution of example as part of build

@Godin Godin added this to the 0.7.6 milestone Jul 24, 2015

@Godin Godin self-assigned this Jul 24, 2015

@Godin Godin changed the title from Fix IProxy in MBeanClient example to Fix MBeanClient example Jul 24, 2015

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof Aug 14, 2015

Member

@Godin Now as we have the IAgent in public API, shouldn't we simply reference this to ensure consistency?

Member

marchof commented Aug 14, 2015

@Godin Now as we have the IAgent in public API, shouldn't we simply reference this to ensure consistency?

GitHub #333: Fix MBeanClient example
This fixes the MBeanClient example and adds a unit test to ensure
interface compatibility in future.
@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof Sep 30, 2015

Member

@Godin Fixed this and added a JUnit test to ensure both APIs are in sync.

Member

marchof commented Sep 30, 2015

@Godin Fixed this and added a JUnit test to ensure both APIs are in sync.

marchof added a commit that referenced this pull request Oct 1, 2015

@marchof marchof merged commit 2c73d99 into master Oct 1, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@marchof marchof deleted the issue-333 branch Oct 1, 2015

@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.