New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't write empty probe arrays to exec files #387

Merged
merged 1 commit into from Mar 21, 2016

Conversation

Projects
None yet
2 participants
@marchof
Member

marchof commented Mar 21, 2016

On the mailing list it was proposed to not dump empty probe arrays to execution data files:

https://groups.google.com/forum/?fromgroups=#!topic/jacoco/wQhTVf2zEtI

In case of repeated dumps (per-test coverage) this can lead to a significant performance improvement:

  • test time: 12hrs -> 1hr
  • jacoco.exec size: 93GB -> 1GB

Within JaCoCo there is no use for empty probe arrays vs. non existing ExecutionData entries. Therefore there is no need to dump such entries.

@marchof marchof added this to the 0.7.7 milestone Mar 21, 2016

@marchof marchof self-assigned this Mar 21, 2016

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof Mar 21, 2016

Member

@Godin May I ask for a review, please?

Member

marchof commented Mar 21, 2016

@Godin May I ask for a review, please?

@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Mar 21, 2016

Member

@marchof sure! This seems to be a huge improvement. Will do today.

Member

Godin commented Mar 21, 2016

@marchof sure! This seems to be a huge improvement. Will do today.

@Godin Godin assigned Godin and unassigned marchof Mar 21, 2016

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof Mar 21, 2016

Member

@Godin Thx, feel free to merge if you agree with the implementation.

Member

marchof commented Mar 21, 2016

@Godin Thx, feel free to merge if you agree with the implementation.

Don't write empty probe arrays
This optimizations reduces the size of exec files significantly in
setups where execution data is dumped after every test case.

@Godin Godin merged commit ea2f49f into master Mar 21, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Godin Godin deleted the issue-387 branch Mar 22, 2016

@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Mar 22, 2016

Member

👍

Member

Godin commented Mar 22, 2016

👍

@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.