New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ASM classes to org.jacoco namespace for jacocoant.jar #39

Merged
merged 1 commit into from Nov 10, 2012

Conversation

Projects
None yet
2 participants
@marchof
Member

marchof commented Nov 7, 2012

With the recent updates of ASM we highly depend on specific Ant versions. Users have reported problems with our jacocoant.jar when conflicting with ASM 3.x. Therefore the ASM classes should be moved to the the org.jacoco namespace.

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof Nov 7, 2012

Member

If we use the shade plugin anyways it would be nice to also minimize jacocoant.jar. Unfortunately this didn't work out for me as org.jacoco.ant-nodeps has no code, so the shade plugin sees no classes to start with (which results in an empty jacocoant.jat file).

Member

marchof commented Nov 7, 2012

If we use the shade plugin anyways it would be nice to also minimize jacocoant.jar. Unfortunately this didn't work out for me as org.jacoco.ant-nodeps has no code, so the shade plugin sees no classes to start with (which results in an empty jacocoant.jat file).

@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Nov 10, 2012

Member

@marchof I think that relocation and minimization are two different issues, so shouldn't we merge this into master already?

Member

Godin commented Nov 10, 2012

@marchof I think that relocation and minimization are two different issues, so shouldn't we merge this into master already?

@ghost ghost assigned marchof Nov 10, 2012

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof Nov 10, 2012

Member

@Godin Makes sense! So please merge if you're o.k. with my changes.

Member

marchof commented Nov 10, 2012

@Godin Makes sense! So please merge if you're o.k. with my changes.

Godin added a commit that referenced this pull request Nov 10, 2012

Merge pull request #39 from jacoco/topic/shadeantasm
Move ASM classes to org.jacoco namespace for jacocoant.jar

@Godin Godin merged commit e23dff9 into master Nov 10, 2012

1 check passed

default The Travis build passed
Details
@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Nov 10, 2012

Member

@marchof FYI: we can solve problem with minimization, if we will stop usage of Tycho (maven-shade-plugin doesn't work with eclipse-plugin packaging type) - see my email to the Dev mailing list and issue #43.

Member

Godin commented Nov 10, 2012

@marchof FYI: we can solve problem with minimization, if we will stop usage of Tycho (maven-shade-plugin doesn't work with eclipse-plugin packaging type) - see my email to the Dev mailing list and issue #43.

@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Dec 18, 2012

Member

Here is a ticket about minimization - #56

Member

Godin commented Dec 18, 2012

Here is a ticket about minimization - #56

@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.