New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more context information when unable to read input during analysis #400

Merged
merged 1 commit into from May 14, 2016

Conversation

Projects
None yet
2 participants
@Godin
Member

Godin commented May 13, 2016

Add location to IOException thrown from

  1. zip.getNextEntry() in analyzeZip
  2. new GZIPInputStream(input) in analyzeGzip
  3. Pack200Streams.unpack(input) in analyzePack200
@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin May 13, 2016

Member

@marchof could you please review?

Member

Godin commented May 13, 2016

@marchof could you please review?

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof May 14, 2016

Member

@Godin Looks good to me!

P.S.: Nice test cases for broken file formats. Looks like we need a (broken) file format mocking library ;-)

Member

marchof commented May 14, 2016

@Godin Looks good to me!

P.S.: Nice test cases for broken file formats. Looks like we need a (broken) file format mocking library ;-)

@marchof marchof merged commit fde254d into master May 14, 2016

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Godin Godin deleted the issue-400 branch May 14, 2016

@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.