New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add useless members into Java 8 interfaces that have only clinit and abstract methods #441

Merged
merged 1 commit into from Aug 16, 2016

Conversation

Projects
None yet
3 participants
@Godin
Member

Godin commented Aug 16, 2016

ProbeCounter.hasMethods should be true for Java 8 interfaces only in case of presence of non-abstract methods.

@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Aug 16, 2016

Member

@marchof could you please review?

Member

Godin commented Aug 16, 2016

@marchof could you please review?

@bjkail

This comment has been minimized.

Show comment
Hide comment
@bjkail

bjkail Aug 16, 2016

Contributor

Looks good to me. As a very minor comment, better grammar for changes.html would be "interfaces that have" ("that" is for discriminating, "which" is for annotating) :-).

Contributor

bjkail commented Aug 16, 2016

Looks good to me. As a very minor comment, better grammar for changes.html would be "interfaces that have" ("that" is for discriminating, "which" is for annotating) :-).

@Godin Godin changed the title from Do not add useless members into Java 8 interfaces which have only clinit and abstract methods to Do not add useless members into Java 8 interfaces that have only clinit and abstract methods Aug 16, 2016

@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Aug 16, 2016

Member

@bjkail thx, fixed

Member

Godin commented Aug 16, 2016

@bjkail thx, fixed

@marchof marchof merged commit 54334f2 into master Aug 16, 2016

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@marchof marchof deleted the issue-441 branch Aug 16, 2016

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof
Member

marchof commented Aug 16, 2016

@Godin Thx!

@Godin Godin referenced this pull request Nov 29, 2016

Closed

Publish new Jacoco release #467

@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.