New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to sign JARs using maven-jarsigner-plugin #466

Merged
merged 1 commit into from Dec 9, 2016

Conversation

Projects
None yet
2 participants
@Godin
Member

Godin commented Dec 3, 2016

The primary use case for signing JaCoCo artifacts was the EclEmma plugin. Next release of EclEmma under Eclipse Foundation umbrella will use JaCoCo bundles from Eclipse Orbit, which signed by eclipse.org anyway. So that no need to sign anymore during our releases.

Initial discussion: https://groups.google.com/d/msg/jacoco-dev/hTLvWPXqaUg/fKoDA3zqBAAJ

@Godin Godin added this to the 0.7.8 milestone Nov 19, 2016

@Godin Godin self-assigned this Nov 19, 2016

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof Dec 5, 2016

Member

@Godin I found more occurences for signing which probably should be removed:

  • jacoco/pom.xml (jarsigner.skip property)
  • org.jacoco.agent.rt/pom.xml (jarsigner.skip property)

As discussed on ML: We mention this in changes.html

Member

marchof commented Dec 5, 2016

@Godin I found more occurences for signing which probably should be removed:

  • jacoco/pom.xml (jarsigner.skip property)
  • org.jacoco.agent.rt/pom.xml (jarsigner.skip property)

As discussed on ML: We mention this in changes.html

@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Dec 6, 2016

Member

@marchof should be fine now

Member

Godin commented Dec 6, 2016

@marchof should be fine now

@Godin Godin requested a review from marchof Dec 7, 2016

@Godin Godin requested a review from marchof Dec 9, 2016

@marchof

marchof approved these changes Dec 9, 2016

@marchof marchof merged commit 52284d1 into master Dec 9, 2016

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@marchof marchof deleted the issue-466 branch Dec 9, 2016

@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.