Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Include runtime dependencies in aggregated reports #498
Hello! I've used project structure similar to following.
api just declares some interfaces, api-implN implements them in a different ways and core binds everything together (now only by integration tests).
How I used it
Since the tests are only in core module I've got everything built, executed and tested, but the coverage report was only for the core module itself.
How I fixed it
Then I switched to report-aggregate and had coverage only for api. data for api-impl1 has been ignored because the scope wasn't either of 'compile' or 'test'. as for the core itself, I guess the data has been ignored because aggregate reports don't include data for the current module. Anyway, this all was fixed by introduction of tests module which included everything needed as compile dependencies. sanity-tool/sanity@cbcdd0d
It's OK to me to keep that structure, but I would like to switch api-impl scopes to runtime and still have the coverage in integration tests.
@okutane Thanks for the detailed explanation! In your scenario the "core" module is a good place to also create the coverage report. Also I think it is reasonable to include runtime dependencies for the scope. For the exec file collection I'm not sure though but at least this will not hurt.
@Godin WDYT? Update documentation and include this PR?