New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce chance of conflict with other agents #555

Merged
merged 1 commit into from Jun 29, 2017

Conversation

Projects
None yet
2 participants
@Godin
Member

Godin commented Jun 28, 2017

As was discussed in #551 : java/lang/UnknownError is intended for use by Virtual Machine and in rare situations, so seems that probability that it is used by other Java agents is lower compared to java/util/UUID and hence we should change code to use it for communication between instrumented classes and agent. In case if even this class is used by other agents, recommendation remains the same - JaCoCo agent should be the first one specified on the command line. Page "Implementation Design" in documentation should be updated accordingly.

@Godin Godin added this to the 0.8.0 milestone Jun 28, 2017

@Godin Godin self-assigned this Jun 28, 2017

@marchof

Hopefully no other agent vendor has the same idea. We should file a patent for it 😜

@marchof marchof merged commit c10af13 into master Jun 29, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@marchof marchof deleted the issue-555 branch Jun 29, 2017

@jonathanamartin jonathanamartin referenced this pull request Dec 13, 2017

Closed

JaCoCo Support? #529

@Godin Godin referenced this pull request Dec 14, 2017

Merged

Support JDK 10 #629

@jacoco jacoco locked as resolved and limited conversation to collaborators Jan 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.