New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Java 9 add "Automatic-Module-Name" to manifests of JAR files #565

Merged
merged 1 commit into from Jul 18, 2017

Conversation

2 participants
@Godin
Member

Godin commented Jul 14, 2017

There is no doubts about module names and their usefulness for the following JARs:

  • org.jacoco.core for org.jacoco.core-<VERSION>.jar
  • org.jacoco.report for org.jacoco.report-<VERSION>.jar
  • org.jacoco.ant for org.jacoco.ant-<VERSION>.jar

Also seems that module name is useful for agent (see #545). While there might be debate about its name and name for org.jacoco.agent-<VERSION>.jar that contains first one as a resource and whose existence might also be a subject of discussion, we can start with

  • org.jacoco.agent.rt for jacocoagent.jar - consistent with names of packages inside JARs.
    Should also be noted that I don't think that existence of class com.vladium.emma.RT in this JAR is a problem - anyway can be solved later when/if it will turn out to be a problem
  • org.jacoco.agent for org.jacoco.agent-<VERSION>.jar - consistent with name of package inside JAR and OSGi bundle name

@Godin Godin added this to the Java 9 milestone Jul 13, 2017

@Godin Godin self-assigned this Jul 14, 2017

@Godin Godin added this to TODO in Java 9 Jul 14, 2017

@marchof

LGTM, thanks!

@marchof marchof merged commit 31575a3 into master Jul 18, 2017

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@marchof marchof deleted the issue-565 branch Jul 18, 2017

@Godin Godin modified the milestones: 0.8.0, Java 9 Jul 18, 2017

@Godin Godin moved this from TODO to DONE in Java 9 Jul 18, 2017

@jacoco jacoco locked as resolved and limited conversation to collaborators Jan 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.