New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter for Groovy generated methods #610

Merged
merged 1 commit into from Oct 17, 2017

Conversation

@datoma
Contributor

datoma commented Oct 10, 2017

Hackergarten Bern Session, co-hacked with @aalmiray and @marchof

highres_465229986

@aalmiray

This comment has been minimized.

Show comment
Hide comment
@aalmiray

aalmiray Oct 11, 2017

Here's the Groovy side of the equation apache/groovy#617

aalmiray commented Oct 11, 2017

Here's the Groovy side of the equation apache/groovy#617

@aalmiray aalmiray referenced this pull request Oct 11, 2017

Closed

GROOVY-8352 #617

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof Oct 11, 2017

Member

@aalmiray Thanks! Two questions:

  • Is there a build or SNAPSHOT available of this Branch so we can test integration? JaCoCo build of this branch is here.
  • What is the Groovy version which will include this feature? So we can make a reference to the required version in our change log.
Member

marchof commented Oct 11, 2017

@aalmiray Thanks! Two questions:

  • Is there a build or SNAPSHOT available of this Branch so we can test integration? JaCoCo build of this branch is here.
  • What is the Groovy version which will include this feature? So we can make a reference to the required version in our change log.
@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Oct 11, 2017

Member

@datoma @aalmiray cool! thank you for contribution! 👍

@aalmiray impatient to try full end-to-end example, so same questions as from @marchof plus maybe you can advise some Groovy-based project where JaCoCo is already used, so that we'll be able to use it as such end-to-end example? And in any case it can be a nice addition for page https://github.com/jacoco/jacoco/wiki/Projects-that-use-JaCoCo 😉

Also wondering if you know examples of generated code that might require filtering and is not represented by generated methods, but is inside of non-generated methods?

Member

Godin commented Oct 11, 2017

@datoma @aalmiray cool! thank you for contribution! 👍

@aalmiray impatient to try full end-to-end example, so same questions as from @marchof plus maybe you can advise some Groovy-based project where JaCoCo is already used, so that we'll be able to use it as such end-to-end example? And in any case it can be a nice addition for page https://github.com/jacoco/jacoco/wiki/Projects-that-use-JaCoCo 😉

Also wondering if you know examples of generated code that might require filtering and is not represented by generated methods, but is inside of non-generated methods?

@aalmiray

This comment has been minimized.

Show comment
Hide comment
@aalmiray

aalmiray Oct 12, 2017

@marchof this feature currently targets Groovy 2.6.0

@Godin I use JaCoCo on the Griffon project. Trust me when I say I'll be the first to try out this new feature 😄

aalmiray commented Oct 12, 2017

@marchof this feature currently targets Groovy 2.6.0

@Godin I use JaCoCo on the Griffon project. Trust me when I say I'll be the first to try out this new feature 😄

@marchof marchof requested a review from Godin Oct 12, 2017

@marchof marchof self-assigned this Oct 12, 2017

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof Oct 16, 2017

Member

@Godin Groovy side has been merged on master, 2_5_x and 2_6_x. Can you review our side?

Member

marchof commented Oct 16, 2017

@Godin Groovy side has been merged on master, 2_5_x and 2_6_x. Can you review our side?

@Godin Godin added this to IN PROGRESS in Filtering Oct 16, 2017

@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Oct 17, 2017

Member

End-to-end test - example.zip
Note that class is abstract, otherwise generated and annotated methods will be marked as synthetic and thus filtered even without this change.

Without this change using JaCoCo 0.7.9:
before

After this change:
after

Member

Godin commented Oct 17, 2017

End-to-end test - example.zip
Note that class is abstract, otherwise generated and annotated methods will be marked as synthetic and thus filtered even without this change.

Without this change using JaCoCo 0.7.9:
before

After this change:
after

@Godin Godin added this to the 0.8.0 milestone Oct 17, 2017

@Godin

Godin approved these changes Oct 17, 2017

@Godin Godin merged commit ec6287a into jacoco:master Oct 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Godin Godin moved this from IN PROGRESS to DONE in Filtering Oct 17, 2017

@aalmiray

This comment has been minimized.

Show comment
Hide comment
@aalmiray

aalmiray Oct 17, 2017

Have to check again with @blackdrag why the GroovyObjectMethods are marked as synthetic if the class is not abstract (which it shouldn't be).

aalmiray commented Oct 17, 2017

Have to check again with @blackdrag why the GroovyObjectMethods are marked as synthetic if the class is not abstract (which it shouldn't be).

@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Oct 17, 2017

Member

@aalmiray well, in any case they are filtered 😉 I was more wondering why generated setters and getters do not have nor line numbers (was expecting line of a field), nor annotation? But that's not so important for end-to-end test here and now that's entirely up to you, Groovy-guys, to mark whatewer you want 😉 Thanks again! 👍 Great collaboration! ❤️

Member

Godin commented Oct 17, 2017

@aalmiray well, in any case they are filtered 😉 I was more wondering why generated setters and getters do not have nor line numbers (was expecting line of a field), nor annotation? But that's not so important for end-to-end test here and now that's entirely up to you, Groovy-guys, to mark whatewer you want 😉 Thanks again! 👍 Great collaboration! ❤️

@jacoco jacoco locked as resolved and limited conversation to collaborators Jan 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.