New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End try-catch blocks before inserted probes. #627

Merged
merged 7 commits into from Dec 20, 2017

Conversation

Projects
None yet
3 participants
@allenhair
Contributor

allenhair commented Dec 2, 2017

Fixes #626

@Godin Godin requested a review from marchof Dec 6, 2017

@marchof

Leave exec file version untouched.

@Godin Godin self-assigned this Dec 16, 2017

@Godin Godin added this to the 0.8.0 milestone Dec 16, 2017

@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Dec 20, 2017

Member

@marchof I restored version of exec-file, polished tests and comments and added changelog entry. Could you please re-review? If all fine, I'll squash and merge.

Member

Godin commented Dec 20, 2017

@marchof I restored version of exec-file, polished tests and comments and added changelog entry. Could you please re-review? If all fine, I'll squash and merge.

@Godin

Godin approved these changes Dec 20, 2017

@marchof

Looks good to me now, thanks!

@Godin Godin merged commit e050f19 into jacoco:master Dec 20, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Dec 20, 2017

Member

@allenhair hope you don't mind that we took over finalization of this, thanks again for your valuable contribution! ❤️

Member

Godin commented Dec 20, 2017

@allenhair hope you don't mind that we took over finalization of this, thanks again for your valuable contribution! ❤️

@allenhair

This comment has been minimized.

Show comment
Hide comment
@allenhair

allenhair Dec 21, 2017

Contributor

No problem @Godin, thanks for pushing this through.

Contributor

allenhair commented Dec 21, 2017

No problem @Godin, thanks for pushing this through.

@jacoco jacoco locked as resolved and limited conversation to collaborators Jan 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.