New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Output Mode 'none' #63

Merged
merged 3 commits into from Jan 9, 2013

Conversation

Projects
None yet
2 participants
@Godin
Member

Godin commented Jan 9, 2013

If the new Agent API #61 or MBean #62 is used, it might not be required to produce any other output. For this a new output mode 'none' should be provided.

@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Jan 9, 2013

Member

@marchof Could you please verify my changes?

Member

Godin commented Jan 9, 2013

@marchof Could you please verify my changes?

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof Jan 9, 2013

Member

@Godin The new mode should also be listed in agent.html

Member

marchof commented Jan 9, 2013

@Godin The new mode should also be listed in agent.html

@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Jan 9, 2013

Member

@marchof I renamed NopController to NoneController, but will not do other cleanups, because for me they don't relate to this feature and should come via separate changeset all together.

Member

Godin commented Jan 9, 2013

@marchof I renamed NopController to NoneController, but will not do other cleanups, because for me they don't relate to this feature and should come via separate changeset all together.

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof Jan 9, 2013

Member

@Godin Perfect! I'll merge.

Member

marchof commented Jan 9, 2013

@Godin Perfect! I'll merge.

marchof added a commit that referenced this pull request Jan 9, 2013

@marchof marchof merged commit d718664 into master Jan 9, 2013

1 check passed

default The Travis build passed
Details

@marchof marchof deleted the issue-63 branch Jan 9, 2013

@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.