New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support analysis of pack200 jars in Jacoco analyzer #91

Merged
merged 1 commit into from Apr 2, 2013

Conversation

Projects
None yet
4 participants
@marchof
Member

marchof commented Mar 22, 2013

This request is originally inspired by this issue: jacoco/eclemma#49 . Allowing pack200'd bundles in Jacoco analyzer would allow to generate reports when jars are pack200.
This would force people to use the pack200'd jar as input rather than the classfile, but I think it's an acceptable and clean improvement.

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof Mar 20, 2013

Member

@mickaelistria Can you please provide a example pack200 JAR?

Member

marchof commented Mar 20, 2013

@mickaelistria Can you please provide a example pack200 JAR?

@mickaelistria

This comment has been minimized.

Show comment
Hide comment
@mickaelistria

mickaelistria Mar 20, 2013

You can create one from this repo:
https://github.com/mickaelistria/bug-jacoco-pack200
just run "mvn clean verify -Ppack200" from the "api" folder, and you'll
see a pack200'd jar in repository/target/repository/plugins.

HTH

Mickael Istria
Eclipse developer at JBoss, by Red Hat http://www.jboss.org/tools
My blog http://mickaelistria.wordpress.com - My Tweets
http://twitter.com/mickaelistria

mickaelistria commented Mar 20, 2013

You can create one from this repo:
https://github.com/mickaelistria/bug-jacoco-pack200
just run "mvn clean verify -Ppack200" from the "api" folder, and you'll
see a pack200'd jar in repository/target/repository/plugins.

HTH

Mickael Istria
Eclipse developer at JBoss, by Red Hat http://www.jboss.org/tools
My blog http://mickaelistria.wordpress.com - My Tweets
http://twitter.com/mickaelistria

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof Mar 22, 2013

Member

@mickaelistria I implemented Pack200 support and attached it as a pull request to this issue. Feel free to review the implementation if you find some time.

Can you please test your scenario, here is a build of this branch: http://download.eclipselab.org/transfer/mho/jacoco-0.6.3.201303221140.zip

Member

marchof commented Mar 22, 2013

@mickaelistria I implemented Pack200 support and attached it as a pull request to this issue. Feel free to review the implementation if you find some time.

Can you please test your scenario, here is a build of this branch: http://download.eclipselab.org/transfer/mho/jacoco-0.6.3.201303221140.zip

@buildhive

This comment has been minimized.

Show comment
Hide comment
@buildhive

buildhive commented Mar 22, 2013

Java Code Coverage Tools » jacoco #43 SUCCESS
This pull request looks good
(what's this?)

@Godin

This comment has been minimized.

Show comment
Hide comment
@Godin

Godin Mar 22, 2013

Member

@marchof FYI results of builds of pull-requests are available from BuildHive, i.e. no need to do custom deployment somewhere. For example for this one: https://buildhive.cloudbees.com/job/jacoco/job/jacoco/43/org.jacoco$jacoco/artifact/org.jacoco/jacoco/0.6.3-SNAPSHOT/jacoco-0.6.3-SNAPSHOT.zip

Member

Godin commented Mar 22, 2013

@marchof FYI results of builds of pull-requests are available from BuildHive, i.e. no need to do custom deployment somewhere. For example for this one: https://buildhive.cloudbees.com/job/jacoco/job/jacoco/43/org.jacoco$jacoco/artifact/org.jacoco/jacoco/0.6.3-SNAPSHOT/jacoco-0.6.3-SNAPSHOT.zip

@marchof

This comment has been minimized.

Show comment
Hide comment
@marchof

marchof Mar 22, 2013

Member

@Godin I didn't knew results are also available for branches, thanks!

Member

marchof commented Mar 22, 2013

@Godin I didn't knew results are also available for branches, thanks!

marchof added a commit that referenced this pull request Apr 2, 2013

Merge pull request #91 from jacoco/issue-91
Support analysis of pack200 jars in Jacoco analyzer

@marchof marchof merged commit 5f208bb into master Apr 2, 2013

1 check passed

default The Travis build passed
Details

@marchof marchof deleted the issue-91 branch Apr 2, 2013

@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.